[sonic-buildimage] create and mount firmware directory on PMON for firmware upgrade support on muxcable #8283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firmware upgrade support on PMON Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12
changed the title
lguohan
previously approved these changes
Jul 29, 2021
lguohan
reviewed
Jul 30, 2021
| @@ -50,6 +50,7 @@ FILESYSTEM_ROOT_USR_SHARE="$FILESYSTEM_ROOT_USR/share" | |||
| FILESYSTEM_ROOT_USR_SHARE_SONIC="$FILESYSTEM_ROOT_USR_SHARE/sonic" | |||
| FILESYSTEM_ROOT_USR_SHARE_SONIC_SCRIPTS="$FILESYSTEM_ROOT_USR_SHARE_SONIC/scripts" | |||
| FILESYSTEM_ROOT_USR_SHARE_SONIC_TEMPLATES="$FILESYSTEM_ROOT_USR_SHARE_SONIC/templates" | |||
| FILESYSTEM_ROOT_USR_SHARE_SONIC_FWFILES="$FILESYSTEM_ROOT_USR_SHARE_SONIC/fwfiles" | |||
There was a problem hiding this comment.
minor comments, can you rename it /usr/share/sonic/firmware/
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12
changed the title
lguohan
approved these changes
Aug 3, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 5, 2021
…de support on muxcable (#8283) This PR creates a directory firmware on the HOST with the path /usr/share/sonic/firmware, as well as this is mounted on PMON container with the same path /usr/share/sonic/firmware. This is required for firmware upgrade support for muxcable as currently by design all Y-Cable API's are called by xcvrd. As such if CLI has to transfer a file to PMON we need to mount a directory from host to PMON just for getting the firmware files. Hence we require this change. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…de support on muxcable (sonic-net#8283) This PR creates a directory firmware on the HOST with the path /usr/share/sonic/firmware, as well as this is mounted on PMON container with the same path /usr/share/sonic/firmware. This is required for firmware upgrade support for muxcable as currently by design all Y-Cable API's are called by xcvrd. As such if CLI has to transfer a file to PMON we need to mount a directory from host to PMON just for getting the firmware files. Hence we require this change. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR creates a directory firmware on the HOST with the path /usr/share/sonic/firmware, as well as this is mounted on PMON
container with the same path /usr/share/sonic/firmware. This is required for firmware upgrade support for muxcable as currently
by design all Y-Cable API's are called by xcvrd. As such if CLI has to transfer a file to PMON we need to mount a directory
from host to PMON just for getting the firmware files. Hence we require this change.
Why I did it
Required to transfer firmware files/binaries from host to PMON for upgrading firmware on Y-Cables.
How I did it
Made the changes inside
files/build_templates/sonic_debian_extension.j2
files/build_templates/docker_image_ctl.j2
How to verify it
Build an image and find the PMON conatiner instance has the required mount.
Which release branch to backport (provide reason below if selected)
Required for upgrading cables
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)