changes to support python3 in mgmt-framework #6038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix specific version for mmh3 for python2 and python3 and Add pyang for python3
Update Dockerfile.j2
|
@sachinholla @anand-kumar-subramanian please review the changes |
jleveque
suggested changes
Nov 25, 2020
|
Retest vsimage please |
|
retest vsimage please |
jleveque
suggested changes
Dec 17, 2020
|
@ben-gale , there is not much activity on this one, can you check? |
|
Retest vsimage please |
jleveque
suggested changes
Dec 21, 2020
| @@ -10,12 +10,20 @@ RUN apt-get update && \ | |||
| apt-get install -y g++ python-dev libxml2 | |||
|
|
|||
| RUN pip install connexion==1.1.15 \ | |||
There was a problem hiding this comment.
Suggest replacing pip with pip2 to ensure the Python 2 version is used here.
jleveque
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)