[openssh] Introduce custom openssh-server package for supporting reverse console SSH #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Oct 26, 2020
src/openssh/patch/0001-Put-style-as-line-number-to-ssh-session-environment-.patch
Outdated
Show resolved
Hide resolved
lguohan
requested changes
Oct 26, 2020
lguohan
reviewed
Oct 26, 2020
src/openssh/patch/0001-Put-style-as-line-number-to-ssh-session-environment-.patch
Outdated
Show resolved
Hide resolved
|
i am not able to review the patch till you have simplfied the patch. |
|
Seems like the openssh-server package were not been built with image. Investigating... But run below command works. |
|
retest this please |
Blueve
force-pushed
the
dev/jika/openssh
branch
from
991917c to
bb3412e
Compare
|
retest this please |
lguohan
reviewed
Oct 28, 2020
lguohan
reviewed
Oct 28, 2020
src/openssh/patch/0001-Put-style-as-line-number-to-ssh-session-environment-.patch
Show resolved
Hide resolved
|
@qiluo-msft, please take a look at this openssh change. |
lguohan
previously approved these changes
Oct 28, 2020
qiluo-msft
reviewed
Oct 28, 2020
src/openssh/patch/0001-Put-style-as-line-number-to-ssh-session-environment-.patch
Outdated
Show resolved
Hide resolved
qiluo-msft
reviewed
Oct 28, 2020
yxieca
previously approved these changes
Oct 29, 2020
qiluo-msft
reviewed
Oct 29, 2020
qiluo-msft
approved these changes
Oct 30, 2020
|
retest vsimage please |
3 similar comments
|
retest vsimage please |
|
retest vsimage please |
|
retest vsimage please |
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…rse console SSH (sonic-net#5717) * Build and install openssh from source * Copy openssh deb package to dest folder * Update make rule * Update sonic debian extension * Append empty line before EOF * Update openssh patch * Add openssh-server to base image dependency * Fix indent type * Fix comments * Use commit id instead of tag id and add comment Signed-off-by: Jing Kan jika@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
To support reverse SSH feature, we need to build a custom openssh-server package and replace the official one in SONiC OS.
(see HLD for more detail: https://github.com/Azure/SONiC/blob/master/doc/console/SONiC-Console-Switch-High-Level-Design.md#313-reverse-ssh)
- How I did it
stylefield in$SSH_TARGET_CONSOLE_LINE.- How to verify it
Test Steps:
Login with below options
Run below command and check the result
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)