[multi-Asic] Add support for multi-asic to swssloglevel #5316
Conversation
| docker exec -$DOCKER_EXEC_FLAGS swss swssloglevel "$@" | ||
| function help() | ||
| { | ||
| echo -e "Usage: $0 -n [0 to $(($NUM_ASIC-1))], where n is the namespace instance" 1>&2; exit 1; |
There was a problem hiding this comment.
Wondering if it would be good to add something like [OPTIONS] in this help message? I feel it might be confusing that this help suggest using swssloglevel -n [0 to n] when inputting swssloglevel, and it shows another completely different help message without a -n option with swssloglevel -n 0
There was a problem hiding this comment.
Good suggestion, I have updated the help string so user knows there are more options.
|
retest this please |
1 similar comment
|
retest this please |
| } | ||
|
|
||
| DEV="" | ||
| PLATFORM=`sonic-cfggen -H -v DEVICE_METADATA.localhost.platform` |
There was a problem hiding this comment.
i think we can use the env file to reduce the overhead of this call.
There was a problem hiding this comment.
thanks ! updated to use the env file.
There was a problem hiding this comment.
@lguohan, Could you confirm if the changes are ok.
|
@abdosi Please take this into 201911 as well. thanks |
* Support for multi-asic platform for swssloglevel command admin@str-acs-1:~$ swssloglevel Usage: /usr/bin/swssloglevel -n [0 to 3] [OPTION]... * Update to use the env file to get the PLATFORM string.
* Support for multi-asic platform for swssloglevel command admin@str-acs-1:~$ swssloglevel Usage: /usr/bin/swssloglevel -n [0 to 3] [OPTION]... * Update to use the env file to get the PLATFORM string.
- Why I did it
Add the option -n to specify the swss docker instance running in a particular namespace to invoke swssloglevel.
- How I did it
Update the script swssloglevel.
- How to verify it
The following options in multi-asic platform.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)