[Multi-ASIC]:Update the template to add ipinip entry for Loopback4096 #5235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
prsunny
reviewed
Aug 25, 2020
| @@ -2,12 +2,13 @@ | |||
| {% set ipv6_addresses = [] %} | |||
| {% set ipv4_loopback_addresses = [] %} | |||
| {% set ipv6_loopback_addresses = [] %} | |||
| {% set loopback_intf_names = ['Loopback0', 'Loopback4096'] %} | |||
There was a problem hiding this comment.
this interface should be in if multi_asic() case right?
There was a problem hiding this comment.
add check to to add Loopback4096 is the device is either Frontend or Backend asic.
There was a problem hiding this comment.
Just a minor suggestion.. we can have it as below in case if we plan to add more loopbacks in future
set loopback_intf_names = ['Loopback0']
if FrontEnd or BackEnd
set loopback_intf_names = loopback_intf_names.append('Loopback4096')
| {%- set ipv4_addresses = ipv4_addresses.append(prefix) %} | ||
| {%- set ipv4_loopback_addresses = ipv4_loopback_addresses.append(prefix) %} | ||
| {%- endif %} | ||
| {%- if prefix | ipv6 and name == 'Loopback0' %} | ||
| {%- if prefix | ipv6 and name in loopback_intf_names %} |
There was a problem hiding this comment.
Looks like an extra space before name
There was a problem hiding this comment.
Fixed in latest commit
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
|
restest vsimage please |
2 similar comments
|
restest vsimage please |
|
restest vsimage please |
prsunny
approved these changes
Aug 27, 2020
|
restest vsimage please |
|
retest vsimage please |
6 similar comments
|
retest vsimage please |
|
retest vsimage please |
|
retest vsimage please |
|
retest vsimage please |
|
retest vsimage please |
|
retest vsimage please |
abdosi
pushed a commit
that referenced
this pull request
Sep 3, 2020
…#5235) Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com> The following changes are done. - Multi asic platform have 2 Loopback interfaces, Loopback0 and Loopback4096. IPinIP decap entries need to be added for both of them. Update the ipinip.json.j2 template to add decap entries for Loopback4096. - Add corressponding unit test
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…sonic-net#5235) Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com> The following changes are done. - Multi asic platform have 2 Loopback interfaces, Loopback0 and Loopback4096. IPinIP decap entries need to be added for both of them. Update the ipinip.json.j2 template to add decap entries for Loopback4096. - Add corressponding unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan arlakshm@microsoft.com
- Why I did it
Multi asic platform have 2 Loopback interfaces, Loopback0 and Loopback4096. IPinIP decap entries need to be added for both of them.
- How I did it
Update the ipinip.json.j2 template to add decap entries for Loopback4096.
Add corressponding unit test
- How to verify it
Verify the ipinip.json is generated properly.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)