Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker-base-buster and docker-config-engine-buster #4480

Merged
merged 3 commits into from
Apr 28, 2020

Conversation

joyas-joseph
Copy link
Contributor

@joyas-joseph joyas-joseph commented Apr 24, 2020

- Why I did it
This change adds support to build dockers using buster as base.

- How I did it

  1. Define docker-base-buster using docker-base-stretch as starting point
  2. Define docker-config-engine-buster using docker-config-engine-stretch
    as starting point.

sonic-mgmt-framework docker is updated to build using buster as base

- How to verify it
During build:
Check that target/docker-base-buster.gz, target/docker-config-engine-buster.gz are being built
Check that the dependencies for sonic-mgmt-framework are being built in target/debs/buster directory

Runtime:

docker history docker-sonic-mgmt-framework:latest
admin@sonic:~$ 
admin@sonic:~$ sonic-cli 
sonic# show interface status 
------------------------------------------------------------------------------------------
Name                Description         Admin          Oper           Speed          MTU            
------------------------------------------------------------------------------------------
Ethernet0           -                   up             down           40GB           9100           
Ethernet4           -                   up             down           40GB           9100           
Ethernet8           -                   up             down           40GB           9100           
Ethernet12          -                   up             down           40GB           9100           
Ethernet16          -                   up             down           40GB           9100           
Ethernet20          -                   up             down           40GB           9100

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Joyas Joseph joyas_joseph@dell.com

This change adds support to build dockers using buster as base.

1) Define docker-base-buster using docker-base-stretch as starting point
2) Define docker-config-engine-buster using docker-config-engine-stretch
   as starting point.

sonic-mgmt-framework docker is updated to build using buster as base

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
slave.mk Outdated Show resolved Hide resolved
slave.mk Outdated Show resolved Hide resolved
slave.mk Outdated Show resolved Hide resolved
@lguohan
Copy link
Collaborator

lguohan commented Apr 24, 2020

what kind of validation have you done since you have switch mgmt-framework to buster docker, have you validated if the mgmt-framework running successful in buster?

@lguohan
Copy link
Collaborator

lguohan commented Apr 24, 2020

btw, can you follow the pr template to fill answers for those questions.

@joyas-joseph
Copy link
Contributor Author

what kind of validation have you done since you have switch mgmt-framework to buster docker, have you validated if the mgmt-framework running successful in buster?

I have loaded the image on an S6000 switch and verified that commands work. I have also verified that libjemalloc2 is the package installed in the docker.

1. Remove SONIC_STRETCH_DOCKERS
	The dockers in SONIC_DOCKER_IMAGES but not in SONIC_STRETCH_DOCKERS are to be built for buster

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
slave.mk Outdated Show resolved Hide resolved
- DOCKER_IMAGES is derived by filtering out SONIC_JESSIE_DOCKERS and SONIC_STRETCH_DOCKERS from SONIC_DOCKER_IMAGES

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
@lguohan lguohan merged commit fc55329 into sonic-net:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants