Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows should use the same tooling as developers #23

Closed
glennmusa opened this issue Feb 24, 2021 · 0 comments · Fixed by #25
Closed

Workflows should use the same tooling as developers #23

glennmusa opened this issue Feb 24, 2021 · 0 comments · Fixed by #25
Assignees

Comments

@glennmusa
Copy link
Contributor

Description

GitHub Actions workflows should use the same Dockerimage that is used for configuring a developer's local environment.

This can be achieved with the jobs.<job id>.container workflow steps: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idcontainer

For now the team could host the image in a private registry, but it should be investigated if there's value in publishing directly to Docker Hub or some other public registry.

Acceptance Criteria

  • Where necessary, workflows make use of the container image from the team's private container registry
  • A new Service Principal is created with solely "acrpull" scope on solely the private registry resource
  • The Service Principal client ID and client secret are stored as encrypted secrets in GitHub
  • The Service Principal credentials are stored in some KeyVault with appropriate RBAC permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant