Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple secrets #81

Open
alxxyz opened this issue Nov 4, 2022 · 7 comments
Open

Add support for multiple secrets #81

alxxyz opened this issue Nov 4, 2022 · 7 comments
Labels
idle Inactive for 14 days wontfix This will not be worked on

Comments

@alxxyz
Copy link

alxxyz commented Nov 4, 2022

At the moment we should call the action multiple times in case we have multiple secrets.
It will be useful to set multiple secrets at once in one action call.

@alxxyz alxxyz added the need-to-triage Requires investigation label Nov 4, 2022
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Nov 18, 2022
@OliverMKing
Copy link
Collaborator

Hi @alxxyz! We don't want to add this feature because it would significantly complicate the way users have to use this action (actions can't take lists or other yaml features as inputs). Running the action multiple times should be just as effective of a solution.

Is there a reason why you want this action to be able to set multiple secrets at the same time instead of just running this action multiple times?

@OliverMKing OliverMKing added wontfix This will not be worked on and removed need-to-triage Requires investigation idle Inactive for 14 days labels Nov 28, 2022
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Dec 12, 2022
@alxxyz
Copy link
Author

alxxyz commented Jan 19, 2023

Hi @OliverMKing, we have to pass 20-30 secrets, and it looks bad when we need to pass such amount of secrets

@github-actions github-actions bot removed the idle Inactive for 14 days label Jan 19, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Feb 2, 2023
@mihiic
Copy link

mihiic commented Oct 18, 2023

@alxxyz
Would this work for you?
Store whole secret manifest inside a github secret, and then apply it as a resource directly?

For example:

Github Secret content:

apiVersion: v1
kind: Secret
metadata:
  name: <secret name>
  namespace: <namespace name>
type: Opaque
data:
  DB_PASSWORD: <b64 of database password>
  RMQ_PASSWORD: <b64 of rmq password>
  JWT_SECRET_KEY: <b64 of jwt secret>

And then in your workflow definition:

      - name: Set secret
        env:
          SECRET_CONTENT: ${{ secrets.APP_SECRET }}
        run: |
          echo "$env:SECRET_CONTENT" | kubectl apply -f -
        shell: bash

@github-actions github-actions bot removed the idle Inactive for 14 days label Oct 18, 2023
Copy link

github-actions bot commented Nov 1, 2023

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Inactive for 14 days wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants