Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Automated check that examples in docs/examples work #68

Closed
pmengelbert opened this issue Jan 9, 2024 · 2 comments · Fixed by #454
Closed

CI: Automated check that examples in docs/examples work #68

pmengelbert opened this issue Jan 9, 2024 · 2 comments · Fixed by #454
Labels
good first issue Good for newcomers

Comments

@pmengelbert
Copy link
Contributor

When the spec changes, we should have an automated check that the examples in docs/examples aren't out of date. This can probably be conditional on changes to the spec.go file.

@pmengelbert pmengelbert added the good first issue Good for newcomers label Jan 9, 2024
@DannyBrito
Copy link
Contributor

Do you mind expanding what were you thinking to accomplish here? When would this check happened? during a PR, merge, cron event? What would be the actions to take if examples are outdated? Open an issue about updating examples? Block PR if using that event and have author also change examples before merging?

@pmengelbert
Copy link
Contributor Author

pmengelbert commented Jan 31, 2024

I think it should happen on every PR. What we want to accomplish is that we always want to have the example docs/examples/go-md2man-2.yml work. This came up because we made changes to the spec, and then suddenly that example didn't work anymore. We don't want our documentation to be out of date with our code.

If the examples are outdated, the job should fail which will prevent merging the PR.

Keep in mind, go-md2man-1.yml intentionally does not work (see https://github.com/Azure/dalec/blob/main/docs/intro.md#building-from-sources)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants