Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Refactor to get rid of need for pasing around the target key #486

Open
1 task
cpuguy83 opened this issue Dec 26, 2024 · 0 comments
Open
1 task

[REQ] Refactor to get rid of need for pasing around the target key #486

cpuguy83 opened this issue Dec 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cpuguy83
Copy link
Member

What kind of request is this?

None

What is your request or suggestion?

Right now we are passing around a targetKey var everywhere which is used to get the right values for various things such as package dependencies which may either be in the root of the spec or under a target with the specified targetKey.

Instead of doing this, I think we should resolve the spec into a single struct with the right pieces merged together so that the targetKey does not need to be passed around.

Are you willing to submit PRs to contribute to this feature request?

  • Yes, I am willing to implement it.
@cpuguy83 cpuguy83 added the enhancement New feature or request label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant