Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayAccess does not appear to work on discriminated object types #775

Open
majastrz opened this issue Nov 2, 2020 · 1 comment
Open

ArrayAccess does not appear to work on discriminated object types #775

majastrz opened this issue Nov 2, 2020 · 1 comment
Labels
bug Something isn't working type system
Milestone
Committed Backlog

Comments

@majastrz
Copy link
Member

majastrz commented Nov 2, 2020 •
edited
Loading

I found this by reading the source of VisitArrayAccessSyntax in the TypeAssignmentVisitor class. We don't appear to have a case for discriminated object types.

In a similar vein, the AreTypesAssignable method will not return correct result when target type is object and the source type is a discriminated object type.
@ghost ghost added the Needs: Triage 🔍 label Nov 2, 2020
@majastrz majastrz added bug Something isn't working and removed Needs: Triage 🔍 labels Nov 2, 2020
@majastrz
Copy link
Member Author

Need to verify this isn't fixed already.

@alex-frankel alex-frankel added this to the v0.4 milestone Mar 22, 2021
@alex-frankel alex-frankel modified the milestones: v0.4, v0.5 Jun 3, 2021
@stephaniezyen stephaniezyen modified the milestones: v0.5, Committed Backlog Mar 11, 2022
@anthony-c-martin anthony-c-martin mentioned this issue Oct 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working type system
Projects
None yet
Milestone
Committed Backlog
Development

No branches or pull requests
3 participants
@alex-frankel @majastrz @stephaniezyen