Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion after the resource type should show = in addition to existing #4584

Closed
pakrym opened this issue Sep 24, 2021 · 6 comments · Fixed by #4599
Closed

Completion after the resource type should show = in addition to existing #4584

pakrym opened this issue Sep 24, 2021 · 6 comments · Fixed by #4599
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pakrym
Copy link
Contributor

pakrym commented Sep 24, 2021

Considering most resource definitions do not use existing customers can be confused about why is that the only completion offered.

Adding = allows efficiently chaining completions:

https://i.imgur.com/AQ1hgEH.gif

@pakrym pakrym added the enhancement New feature or request label Sep 24, 2021
@ghost ghost added the Needs: Triage 🔍 label Sep 24, 2021
@pakrym
Copy link
Contributor Author

pakrym commented Sep 24, 2021

cc @majastrz

@pakrym
Copy link
Contributor Author

pakrym commented Sep 24, 2021

In case you think this feature is appropriate: #4599

@majastrz
Copy link
Member

We've had a few discussions that went back and forth on the topic of including completions for operator-like things. I was against this originally, but it looks really good in practice. It also has the benefit of guiding inexperienced users towards the correct syntax ("pit of success"). Without this, they'd have to look up an example to figure it out or check the error message.

@alex-frankel, @anthony-c-martin, @shenglol thoughts?

@shenglol
Copy link
Contributor

I'm fine with it. I was also against this because typing = is sort of a muscle memory, but I think @pakrym has a good point, and I agree with @majastrz that it looks good in practice - that GIF convinced me.

@alex-frankel
Copy link
Collaborator

I'm good with it also

@anthony-c-martin
Copy link
Member

I'm all for it. IMO - the more useful completions/code fixes we can provide the better, as they serve as a way of learning the language. For example, existing was pretty undiscoverable before we added that completion.

@majastrz majastrz added this to the v0.5 milestone Sep 27, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants