Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not block creating compilation if bicepconfig.json on language server side #4471

Closed
bhsubra opened this issue Sep 16, 2021 · 0 comments · Fixed by #4576
Closed

Do not block creating compilation if bicepconfig.json on language server side #4471

bhsubra opened this issue Sep 16, 2021 · 0 comments · Fixed by #4576
Assignees
Labels
Milestone

Comments

@bhsubra
Copy link
Contributor

bhsubra commented Sep 16, 2021

We currently don't create compilation if bicepconfig.json is invalid:

// this is a fatal error likely due to a code defect

We should log diagnostics and go ahead with creating compilation with default bicepconfig.json settings as user can get much of the functionality even with a malformed config file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants