Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Command Palette Commands #1182

Closed
MarcusFelling opened this issue Dec 17, 2020 · 7 comments
Closed

VS Code Command Palette Commands #1182

MarcusFelling opened this issue Dec 17, 2020 · 7 comments
Labels
devdiv Related to Bicep tooling efforts in DevDiv enhancement New feature or request P2 This is important to be completed, but you may not get to it

Comments

@MarcusFelling
Copy link
Collaborator

It would be nice to have Command Palette commands for common Bicep operations.

These commands could assist with things like running Bicep Build and inserting snippets, similar to VS Code ARM Tools:

image

On the Microsoft side, Command Pallete commands are trackable and could help us better understand the Bicep authoring experience. Quickstarts and other docs could reference these to help with adoption.

@MarcusFelling MarcusFelling added the enhancement New feature or request label Dec 17, 2020
@ghost ghost added the Needs: Triage 🔍 label Dec 17, 2020
@majastrz
Copy link
Member

Can you provide examples of the commands that you would like to see in our extension?

@MarcusFelling
Copy link
Collaborator Author

I think it would be nice to run the 3 commands Alex has listed in this issue: #858 (after the integration is complete?), but I think the real value would come from inserting snippets, where the palette acts as a wizard to fill in values.

Example using the ARM tools:

  1. Ctrl + Shift + P
  2. Type "ARM" -> Insert Item
    image
  3. Resource
    image
  4. App Service Plan
    image
  5. Snippet gets added
    image

We could even go a step further to fill in the required property values OR the user can skip and select all defaults.

@MarcusFelling
Copy link
Collaborator Author

To add to this, there could be a cmd to deploy which opens a new terminal with CLI values populated for the bicep file that's in focus. Depending on the scope, the user could use the palette to select a subscription, resource group, management group, or tenant (similar to Azure Resource Groups extension)

@alex-frankel alex-frankel added this to the Committed Backlog milestone Jun 10, 2021
@ucheNkadiCode ucheNkadiCode added devdiv Related to Bicep tooling efforts in DevDiv P2 This is important to be completed, but you may not get to it labels Jan 12, 2022
@ucheNkadiCode
Copy link
Contributor

ucheNkadiCode commented Jan 12, 2022

@StephenWeatherford and @bhsubra I think we should ultimately split this into each work item, bicep build, etc, we can discuss later

@StephenWeatherford
Copy link
Contributor

Not sure there's actually any work to do here. Placing things in the command palette is part of hooking up any command. We currently have these exposed there:

image

Although they only show when you have a bicep file opened (which in my mind is a little weird).

@majastrz
Copy link
Member

Agree that we can probably close this issue, but the commands listed above do require a Bicep file to be active.

@ucheNkadiCode
Copy link
Contributor

ucheNkadiCode commented Jan 13, 2022

Thanks for that information @StephenWeatherford and @majastrz! I believe we should make our Bicep commands listed at all times, even if a user doesn't not have a bicep file in the directory. There is a precedent set that if a user installs our extension, they want Bicep available. I think what we should do the default behavior in the picture below.

If the user does not have a bicep file in the directory, we can fail gracefully and ask if they want us to create an empty Bicep file with their permission in the root directory.

This would happen if they run any Bicep command that requires a Bicep file to be present (aka any of our current commands). In the case of Docker extension, we have "Add dockerfiles to workspace" which is of course accessible at any point in your dev cycle.

image

But I'll make a seperate issue for this because this behavior does exist.

@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
devdiv Related to Bicep tooling efforts in DevDiv enhancement New feature or request P2 This is important to be completed, but you may not get to it
Projects
None yet
Development

No branches or pull requests

5 participants