Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BranchPolicyException breaking change approval labels #7860

Closed
mikekistler opened this issue Mar 12, 2024 · 1 comment
Closed

BranchPolicyException breaking change approval labels #7860

mikekistler opened this issue Mar 12, 2024 · 1 comment
Assignees
@konrad-jamrozik
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@mikekistler
Copy link
Member

mikekistler commented Mar 12, 2024 •
edited by konrad-jamrozik
Loading

This is a minor swizzle to our labeling design. Please

  • change the Versioning-Approved-NotReleased to Versioning-Approved-BranchPolicyException
  • add a BreakingChange-Approved-BranchPolicyException label

"NotReleased" is a bit too bland and nondescriptive. These are exceptions to the branch policy and we should make the label communicate that clearly.

Notes by kojamroz:
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 12, 2024
@konrad-jamrozik konrad-jamrozik self-assigned this Mar 12, 2024
@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 12, 2024
This was referenced Mar 12, 2024
Open
Closed
@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Apr 8, 2024 •
edited
Loading

  • Pull Request 542484: Add BranchPolicyException to breaking changes approval labels
  • Update labels on the specs repos:
    • Add BranchPolicyException for Breaking change and Versioning approvals, in 4 repos: specs, specs-pr, test-repo-billy/specs and test-repo-billy/specs-pr
    • Migrate away from and remove Versioning-Approved-NotReleased labels from the repos
  • Update the docs - I updated the docs previously, in PR 932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Azure SDK EngSys 📈
Archived in project
Spec PR Tools
Status: 🎊 Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@konrad-jamrozik @mikekistler