Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LintDiff][False positive] Invalid validation on ResourceMustReferenceCommonTypes #6131

Open
FumingZhang opened this issue May 5, 2023 · 2 comments
Assignees
Labels
ARM bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@FumingZhang
Copy link
Member

Describe the bug
Alert on

Resource definition 'ManagedClusterSnapshot' must reference the common types resource definition for ProxyResource or TrackedResource. Location: aks/preview/2023-05-02-preview/managedClusters.json#L7004

is invalid, as the model has been declared with

      "allOf": [
        {
          "$ref": "../../../../../../common-types/resource-management/v3/types.json#/definitions/TrackedResource"
        }
      ],

To Reproduce
See check result.

Expected behavior
Should not raise alert on this.

Screenshots
See check result.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented May 5, 2023

@konrad-jamrozik konrad-jamrozik transferred this issue from Azure/azure-openapi-validator May 9, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this May 9, 2023
@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels May 9, 2023
@konrad-jamrozik konrad-jamrozik changed the title Invalid validation on ResourceMustReferenceCommonTypes [LintDiff] Invalid validation on ResourceMustReferenceCommonTypes May 9, 2023
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 9, 2023
@konrad-jamrozik konrad-jamrozik added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels May 11, 2023
@rkmanda rkmanda added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels May 17, 2023
@konrad-jamrozik konrad-jamrozik changed the title [LintDiff] Invalid validation on ResourceMustReferenceCommonTypes [LintDiff][False positive] Invalid validation on ResourceMustReferenceCommonTypes May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Status: 📋 Backlog
Status: 📋 Backlog
Development

No branches or pull requests

4 participants