Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KV] azure-keyvault-xxx packages should not depend on azure-common #8370

Closed
lmazuel opened this issue Nov 4, 2019 · 4 comments · Fixed by #9906
Closed

[KV] azure-keyvault-xxx packages should not depend on azure-common #8370

lmazuel opened this issue Nov 4, 2019 · 4 comments · Fixed by #9906
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@lmazuel
Copy link
Member

lmazuel commented Nov 4, 2019

There is no reason too, and I'm curious to see what reason if there is one I didn't find :)

@lmazuel lmazuel added KeyVault Client This issue points to a problem in the data-plane of the library. labels Nov 4, 2019
@lmazuel
Copy link
Member Author

lmazuel commented Nov 4, 2019

After reviwing in more details, it's used for multiapi client mixin. So yes it's used right now, we might want to ask the bigger question: should multiapi mixin be part of azure-common at all for track 2?

@lmazuel
Copy link
Member Author

lmazuel commented Nov 4, 2019

@johanste for opinion, do we want to keep azure-common as our base for profiles definition and multiapi mixin?

@johanste
Copy link
Member

johanste commented Nov 4, 2019

I don't want to keep the dependency on azure-common since that has other pieces that we are trying to get rid of.

@lmazuel
Copy link
Member Author

lmazuel commented Nov 6, 2019

then we need a plan for Profiles definition going forward. Might just be "azure-profile" package, TBD

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants