Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement async interactive authentication #6451

Closed
chlowell opened this issue Jul 23, 2019 · 6 comments
Closed

Implement async interactive authentication #6451

chlowell opened this issue Jul 23, 2019 · 6 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-author-feedback Workflow: More information is needed from author to address the issue.
Milestone

Comments

@chlowell
Copy link
Member

No description provided.

@chlowell chlowell added this to the Sprint 156 milestone Jul 23, 2019
@chlowell chlowell added Azure.Identity Client This issue points to a problem in the data-plane of the library. labels Jul 23, 2019
@chlowell chlowell modified the milestones: Sprint 156, Sprint 157 Jul 31, 2019
@chlowell chlowell self-assigned this Aug 6, 2019
@chlowell chlowell modified the milestones: Sprint 157, Backlog Sep 12, 2019
@lmazuel lmazuel assigned xiangyan99 and unassigned chlowell Dec 17, 2021
@astafan8
Copy link

Similar to #6293, I've noticed that this task has been open for ~3 years, so I wonder what is the known "workaround" to use an interactive credential with async clients e.g. AsyncDataLakeServiceClient? Is there a way to acquire token using sync interactive credential class and pass it to (e.g.) AsyncDataLakeServiceClient? Or perhaps a completely other way?

@xiangyan99
Copy link
Member

Thanks for asking.

A simple workaround is you can implement an async interactive credential class and in

async def get_token(self, *scopes: str, **kwargs: "Any") -> "AccessToken":

method, you call the sync one and return the token.

Please let us know if it doesn't work.

@xiangyan99 xiangyan99 added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Sep 15, 2022
@astafan8
Copy link

thank you @xiangyan99 ! indeed, this workaround worked very well.

Shall such an implementation be submitted to the package? I'm happy to open a PR. Wouldn't even a minimal class implementing this be of help? or are there concerns?

@xiangyan99
Copy link
Member

Thanks for the suggestion.

We decide not to ship the workaround in our package because we don't want to lie to our customers. :)

I will have a gist snippet to demo the workaround.

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Sep 23, 2022
@ghost
Copy link

ghost commented Sep 23, 2022

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@ghost ghost closed this as completed Oct 7, 2022
@xiangyan99
Copy link
Member

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label Oct 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-author-feedback Workflow: More information is needed from author to address the issue.
Projects
None yet
Development

No branches or pull requests

3 participants