Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Generative Readme And Sample Issue #33656

Closed
jerryshia opened this issue Dec 26, 2023 · 12 comments
Closed

AI Generative Readme And Sample Issue #33656

jerryshia opened this issue Dec 26, 2023 · 12 comments
Assignees
Labels
AI Client This issue points to a problem in the data-plane of the library. Docs Machine Learning Service Attention Workflow: This issue is responsible by Azure service team. test-manual-pass

Comments

@jerryshia
Copy link
Member

jerryshia commented Dec 26, 2023

Section link1
image

Reason:
Link error.

Suggestion:
Update Azure Machine Learning Workspace to Azure OpenAI Service. Add link "https://learn.microsoft.com/en-us/azure/ai-services/openai/overview "to Azure OpenAI Service

Section link1

image

Reason:
'module' object is not callable

Suggestion:
Update code to from azure.ai.generative.evaluate import evaluate

Section link1

image

Reason:
Link not included.

Suggestion:
Update code to Samples ,Add link"https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/ai/azure-ai-generative/samples" to Samples

@rohit-ganguly , @lmazuel , @mayurid , @diondrapeck for notification.

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 26, 2023
@v-xuto v-xuto added Docs Client This issue points to a problem in the data-plane of the library. test-manual-pass OpenAI AI needs-team-triage Workflow: This issue needs the team to triage. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Dec 26, 2023
@diondrapeck
Copy link
Member

#33515 was already in progress to address 3

I'll make PRs to address 1 and 2 and close this Issue once they're merged.

@xiangyan99 xiangyan99 added Machine Learning Service Attention Workflow: This issue is responsible by Azure service team. and removed needs-team-triage Workflow: This issue needs the team to triage. OpenAI labels Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/azure-ml-sdk @azureml-github.

1 similar comment
Copy link

github-actions bot commented Jan 2, 2024

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/azure-ml-sdk @azureml-github.

@diondrapeck diondrapeck self-assigned this Jan 2, 2024
@diondrapeck
Copy link
Member

@jerryshia - #3 is actually not a bug. That samples folder you linked to is the internal folder we use in the codebase to host in-line code examples that are shown along with reference documentation. That's not what we want users to go to directly to learn how to use the product.

We did have a typo in that Samples link which was addressed in #33515, but the solution was to redirect it to azureai-samples which is our dedicated Code Samples repository with e2e examples of different scenarios to use the product with.

I'll be addressing #1 in PR #33968 and #2 in a later PR.

@jerryshia
Copy link
Member Author

@diondrapeck I agree with your point of view on #3.
About #1 ,the PR #33968 is not we expected. The package in #33968 is not the same as the target package we want to modify. The package we intend to change is the azure-ai-generative ,while the package modified in the PR is the azure-ai-ml. Please follow my suggestion to do the update.

@luigiw
Copy link
Contributor

luigiw commented Jan 24, 2024

Thank you for the feedback, @jerryshia! For #1, it should link to creating an AI project. Do you agree?

@diondrapeck
Copy link
Member

@jerryshia - #33968 is still in progress. I'm fixing a batch of reference docs bugs across our 3 SDKs in that PR, so sorry for the confusion but that azure-ai-ml change is intentional. I will add the changes we've discussed here for the AI SDKs today.

@diondrapeck
Copy link
Member

@jerryshia @luigiw - the PR is ready. Can you both review + merge?

@diondrapeck
Copy link
Member

#2 must have been fixed by someone else because evaluate() is now exported in the __init__.py file for the evaluate module: https://github.com/Azure/azure-sdk-for-python/blob/27316b3a56ae9181e050afa2df2381d5872b54a0/sdk/ai/azure-ai-generative/azure/ai/generative/evaluate/__init__.py#L16C1-L17C1

and I just successfully imported it from there locally:

image

@jerryshia
Copy link
Member Author

@diondrapeck For issue #33968, LGTM.
About #2, yes, the package azure.ai.generative.evaluate can be successfully imported, but the package in the sample file is azure.ai.generative. So we want to update azure.ai.generative to azure.ai.generative.evaluate

@diondrapeck
Copy link
Member

diondrapeck commented Jan 26, 2024

Ah yes, I misread your sentence. Thanks - I'll update it.

@jerryshia
Copy link
Member Author

Issue fixed.

@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AI Client This issue points to a problem in the data-plane of the library. Docs Machine Learning Service Attention Workflow: This issue is responsible by Azure service team. test-manual-pass
Projects
None yet
Development

No branches or pull requests

5 participants