Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserPassCredentials showing password in debug mode #2321

Closed
rems75 opened this issue Mar 30, 2018 · 2 comments
Closed

UserPassCredentials showing password in debug mode #2321

rems75 opened this issue Mar 30, 2018 · 2 comments
Labels
ARM bug This issue requires a change to an existing behavior in the product in order to be resolved. Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@rems75
Copy link

rems75 commented Mar 30, 2018

Hello,

I'm using the UserPassCredentials class from azure.common.credentials.
When initializing an instance of the class with a logging level at DEBUG, the password is shown in plain text at at least three locations:

  • 03/30/2018 06:16:46 PM (DEBUG): Supplying headers {'Accept': 'application/json', 'Content-Type': 'application/x-www-form-urlencoded;charset=UTF-8'} and data {'resource': 'https://vault.azure.net', 'grant_type': 'password', 'client_id': '------', 'username': 'r____@microsoft.com', 'password': '_______}

  • 03/30/2018 06:16:52 PM (DEBUG): Request body was resource=https%3A%2F%2Fvault.azure.net&grant_type=password&client_id=----------&username=r_______%40microsoft.com&password=--------

  • 03/30/2018 06:16:52 PM (DEBUG): Prepared fetch token request body grant_type=password&client_id=-------&password=--------&resource=https%3A%2F%2Fvault.azure.net&username=r______%40microsoft.com

Is this something done on purpose? It seems a bit 'unsafe' to me.

@lmazuel
Copy link
Member

lmazuel commented Apr 4, 2018

Could you confirm what version of msrest you used? There is a fix for that in 0.4.27. If you don't have this one, could you update to this version and tell me if it's all gone?

@lmazuel lmazuel added bug This issue requires a change to an existing behavior in the product in order to be resolved. ARM labels Apr 4, 2018
@lmazuel
Copy link
Member

lmazuel commented Jul 24, 2018

Supposed to be fixed, and the backend is being rewritten anyway in msrestazure 0.6.0 (Azure/msrestazure-for-python#94)

@lmazuel lmazuel closed this as completed Jul 24, 2018
@bsiegel bsiegel added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 26, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ARM bug This issue requires a change to an existing behavior in the product in order to be resolved. Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

3 participants