Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharedTokenCacheCredential uses MSAL #11767

Closed
chlowell opened this issue Jun 2, 2020 · 2 comments
Closed

SharedTokenCacheCredential uses MSAL #11767

chlowell opened this issue Jun 2, 2020 · 2 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@chlowell
Copy link
Member

chlowell commented Jun 2, 2020

SharedTokenCacheCredential must handle its cache as MSAL does because that cache is shared by applications accessing it through MSAL. The current approach, duplicating MSAL Python's logic as needed, is fragile and error prone, and adds considerable complexity. It would be better for the credential to access the cache through MSAL.

For the async SharedTokenCacheCredential, this is blocked by AzureAD/microsoft-authentication-library-for-python#88.

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Jun 2, 2020
@chlowell chlowell added this to the Backlog milestone Jun 2, 2020
@chlowell
Copy link
Member Author

#13490 made this change to the sync credential.

Copy link

Hi @chlowell, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

2 participants