Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureMonitorDistro] Add field validation to Integration Tests (part2) #44538

Merged
merged 14 commits into from
Jun 14, 2024

Conversation

TimothyMothra
Copy link
Contributor

@TimothyMothra TimothyMothra commented Jun 12, 2024

Follow up to #44429

This PR builds on the previous and adds the remaining fields to the validation.

Notes

  • Several fields cannot be validated because they are unique per each test run and would break the Recorded/Playback test scenario. Please call out any fields that you think should be validated and lets discuss a strategy.

@github-actions github-actions bot added the Monitor - Distro Monitor OpenTelemetry Distro label Jun 12, 2024
@TimothyMothra TimothyMothra changed the title [AzureMonitor] fully implement field validation in Integration test [AzureMonitorDistro] Add field validation to Integration Tests (part2) Jun 12, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@TimothyMothra TimothyMothra enabled auto-merge (squash) June 14, 2024 20:16
@TimothyMothra TimothyMothra merged commit 717ba30 into main Jun 14, 2024
17 checks passed
@TimothyMothra TimothyMothra deleted the tilee/202406_integrationtest_validation2 branch June 14, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor - Distro Monitor OpenTelemetry Distro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants