-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AzureMonitorDistro] Add field validation to Integration Tests (part2) #44538
Merged
TimothyMothra
merged 14 commits into
main
from
tilee/202406_integrationtest_validation2
Jun 14, 2024
Merged
[AzureMonitorDistro] Add field validation to Integration Tests (part2) #44538
TimothyMothra
merged 14 commits into
main
from
tilee/202406_integrationtest_validation2
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMothra
changed the title
[AzureMonitor] fully implement field validation in Integration test
[AzureMonitorDistro] Add field validation to Integration Tests (part2)
Jun 12, 2024
API change check API changes are not detected in this pull request. |
TimothyMothra
commented
Jun 13, 2024
.../tests/Azure.Monitor.OpenTelemetry.AspNetCore.Integration.Tests/TelemetryValidationHelper.cs
Outdated
Show resolved
Hide resolved
TimothyMothra
requested review from
cijothomas,
reyang,
rajkumar-rangaraj and
vishweshbankwar
as code owners
June 13, 2024 17:04
rajkumar-rangaraj
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #44429
This PR builds on the previous and adds the remaining fields to the validation.
Notes