[AzureMonitorDistro] Add field validation to Integration Tests (part1) #44429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logging to debug locally.
|
API change check API changes are not detected in this pull request. |
TimothyMothra
changed the title
TimothyMothra
requested review from
cijothomas,
reyang,
rajkumar-rangaraj and
vishweshbankwar
as code owners
TimothyMothra
changed the title
vishweshbankwar
approved these changes
Jun 10, 2024
...Core/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Integration.Tests/DistroWebAppLiveTests.cs
Show resolved
Hide resolved
...Core/tests/Azure.Monitor.OpenTelemetry.AspNetCore.Integration.Tests/DistroWebAppLiveTests.cs
Show resolved
Hide resolved
rajkumar-rangaraj
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding field validation in our Integration Tests.
This adds an ExpectedTelemetry struct with properties.
Each properties are iterated and compared to the telemetry returned from Log Analytics.
Changes
Debug.WriteLinefor local debugging andTestContext.Out.WriteLinefor test output.structsfor expected telemetry:ExpectedAppDependency,ExpectedAppRequest,ExpectedAppMetric,ExpectedAppTrace.These names match the table names in Log Analytics and the struct Property names match the field names.
I'll finished adding the remaining fields to these structs in a follow up PR.