Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ]/[BUG] [Distributed tracing] Report failures properly #33080

Closed
lmolkova opened this issue Dec 15, 2022 · 0 comments
Closed

[FEATURE REQ]/[BUG] [Distributed tracing] Report failures properly #33080

lmolkova opened this issue Dec 15, 2022 · 0 comments
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)

Comments

@lmolkova
Copy link
Member

lmolkova commented Dec 15, 2022

Library name

Azure.Core

Please describe the feature.

  1. Apparently, Scope.Failed(ex) does not work on OTel path (for ActivitySource). We need to use Activity.SetStatus method there.

  2. Also, we should add something like Scope.Failed(string) that would set error with optional description when there is no exception to report, like in RequestActivityPolicy - otel.status_code was an old workaround and is not expected to work in a generic case

  3. We need to set error conditionally in RequestActivityPolicy depending on RequestOptions and don't fail HTTP activity when configured so.

@lmolkova lmolkova added Azure.Core Monitor - ApplicationInsights OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) labels Dec 15, 2022
@jsquire jsquire added the Client This issue points to a problem in the data-plane of the library. label Dec 15, 2022
@JoshLove-msft JoshLove-msft self-assigned this Feb 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
@scottaddie scottaddie added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - ApplicationInsights labels Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)
Projects
None yet
Development

No branches or pull requests

4 participants