[BUG] HLC + DPG + Exceptions?

[tg-msft]

I’m having a problem trying to use DPG via HLC around exceptions:

• Storage HLCs use its own StorageClientDiagnostics ExtractFailureContent when it throws.
• Storage using DPG throws via RequestFailedException’s .ctor which just calls the naïve default for extracting that can’t parse Storage’s XML response body.

If I’m surfacing this to Storage customers, it won’t populate the RequestFailedException.ErrorCode, it won’t use the additionalInfo for a great exception message, etc. Not having ErrorCode in particular is a deal breaker.

I think this also breaks the DPG "don't throw" story because I'll get different exceptions if the client throws vs. if I do myself.

[tg-msft]

Closing as this no longer repros:

using Azure;
using Azure.Storage;
using Azure.Storage.Blobs;
using Azure.Storage.Blobs.Specialized;

BlobClient blob = new(new Uri("..."), new StorageSharedKeyCredential("...", "..."));
BlobLeaseClient lease = blob.GetBlobLeaseClient();

try
{
    await lease.AcquireAsync(TimeSpan.FromHours(3));
}
catch (RequestFailedException ex)
{
    Console.WriteLine($"Convenience: {ex}");
}

try
{
    await lease.AcquireAsync(TimeSpan.FromHours(3), conditions: null, new RequestContext());
}
catch (RequestFailedException ex)
{
    Console.WriteLine($"Protocol: {ex}");
}

try
{
    RequestContext ctx = new();
    ctx.AddClassifier(400, isError: false);
    Response raw = await lease.AcquireAsync(TimeSpan.FromHours(3), conditions: null, ctx);
    throw new RequestFailedException(raw);
}
catch (RequestFailedException ex)
{
    Console.WriteLine($"Classified then thrown: {ex}");
}