Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLC] Design serialization for LLC models s.t. it addresses broader issues #25045

Closed
annelo-msft opened this issue Nov 1, 2021 · 9 comments
Closed
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Nov 1, 2021

Related issues:

@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. DPG labels Nov 1, 2021
@annelo-msft
Copy link
Member Author

@DBojsen
Copy link

DBojsen commented Jan 10, 2022

Hi @annelo-msft
Any progress on this?
BR David

@annelo-msft
Copy link
Member Author

Hi @DBojsen - yes, we are making progress on it, although I don't have an answer for you just yet on what the outcome will be. One thing that is different from when we initially corresponded about this is that I am now confident that we will be able to expose serialization capabilities publicly. We are working on the details in a way we can solve the problem holistically for the SDK, which is why there's a greater investment of time needed. Thanks!

@rquackenbush
Copy link

Hi @annelo-msft - I've just run into the same roadblock. Any updates?
Thanks

@DBojsen
Copy link

DBojsen commented Sep 20, 2022

Hi @annelo-msft - I've just run into the same roadblock. Any updates?
Thanks

Hi @rquackenbush

I solved my issue for the time being by using reflection. Perhaps that will work for you also?!

BR David

@pallavit
Copy link
Contributor

pallavit commented Dec 18, 2023

@annelo-msft I am assuming this issue is getting resolved as part of the model reader writer support.
/cc: @m-nash

@annelo-msft
Copy link
Member Author

The goal of this issue was to track the various model serialization issues in one place so that when we provided a solution they would all be addressed with one set of types. I assume @m-nash was aware of the design requirements and has been using them in the serialization work.

Copy link

github-actions bot commented Mar 4, 2024

Hi @annelo-msft, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@annelo-msft
Copy link
Member Author

I believe this has been addressed with the new IPersistableModel<T> interfaces in System.ClientModel v1.0.0

@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

4 participants