Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLC] [Feature] Make "Default ResponseClassifier" logic available in the pipeline #24051

Closed
annelo-msft opened this issue Sep 16, 2021 · 3 comments
Closed

[LLC] [Feature] Make "Default ResponseClassifier" logic available in the pipeline #24051

annelo-msft opened this issue Sep 16, 2021 · 3 comments
Assignees
@annelo-msft
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. needs-design
Milestone
[2021] September

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Sep 16, 2021 •
edited
Loading

The information regarding which status codes are successes/failures currently lives only in generated code, and is not passed into the pipeline, so cannot currently be used to make a Response.IsError decision according to the "default ResponseClassifier" logic.

This issue tracks the work to determine how to make that logic available in the pipeline and for the Response.IsError field.
@annelo-msft annelo-msft added the Client This issue points to a problem in the data-plane of the library. label Sep 16, 2021
@annelo-msft annelo-msft added this to the [2021] October milestone Sep 16, 2021
@annelo-msft
Copy link
Member Author

Initial design to implement and consider:

  • Design code that can be generated in order to pass success/fail status code information into Core before we call the send the message through the pipeline

@annelo-msft annelo-msft changed the title [LLC][Feature] Make "Default ResponseClassifier" logic available in Core [LLC] [Feature] Make "Default ResponseClassifier" logic available in Core Sep 16, 2021
@annelo-msft annelo-msft mentioned this issue Sep 16, 2021
Closed
@annelo-msft
Copy link
Member Author

Depends on #24053

@annelo-msft annelo-msft self-assigned this Sep 16, 2021
@annelo-msft annelo-msft changed the title [LLC] [Feature] Make "Default ResponseClassifier" logic available in Core [LLC] [Feature] Make "Default ResponseClassifier" logic available in the pipeline Sep 17, 2021
@annelo-msft annelo-msft mentioned this issue Sep 17, 2021
Merged
@annelo-msft
Copy link
Member Author

Design is completed, issue tracking implementation for LLC is here: Azure/autorest.csharp#1535

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@annelo-msft annelo-msft

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. needs-design
Projects
None yet
Milestone
[2021] September
Development

No branches or pull requests
1 participant
@annelo-msft