Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[text analytics] add bing ID property for LinkedEntity #14091

Closed
iscai-msft opened this issue Aug 10, 2020 · 5 comments · Fixed by #14805
Closed

[text analytics] add bing ID property for LinkedEntity #14091

iscai-msft opened this issue Aug 10, 2020 · 5 comments · Fixed by #14805
Assignees
@maririos
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Milestone
[2020] September

Comments

@iscai-msft
Copy link

No description provided.

@iscai-msft iscai-msft added Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics labels Aug 10, 2020
@iscai-msft iscai-msft added this to the [2020] September milestone Aug 10, 2020
@maririos
Copy link
Member

Blocked until service adds property to swagger

@maririos
Copy link
Member

Azure/azure-rest-api-specs#10440.
Why have a separate property and not use LinkedEntity.Id?

@maririos
Copy link
Member

maririos commented Sep 1, 2020 •
edited
Loading

BingId is used to find the entity in the Microsoft graph using the Bing Entity Search (BES) API
It is for more advanced usersI

@maririos
Copy link
Member

maririos commented Sep 1, 2020 •
edited
Loading

Because of how specific it is, I'm proposing going with BingEntitySearchAPIId instead of BingID to make sure the user knows that this is not for everyone and that it is "complicated" enough that unless they need it, they shouldn't care

@maririos
Copy link
Member

maririos commented Sep 1, 2020

There are more Bing APIs https://docs.microsoft.com/en-us/azure/cognitive-services/bing-web-search/bing-api-comparison?toc=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fazure%2Fcognitive-services%2Fbing-autosuggest%2Ftoc.json&bc=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fazure%2Fbread%2Ftoc.json
which makes us more convinced that being specific about the name of the service is the way to go

@maririos maririos mentioned this issue Sep 2, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maririos maririos

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Milestone
[2020] September
Development

Successfully merging a pull request may close this issue.

[TA] Add BingEntitySearchApiId property to LinkedEntity maririos/azure-sdk-for-net
2 participants
@maririos @iscai-msft