Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out domain parameter in PPI #14083

Closed
maririos opened this issue Aug 10, 2020 · 4 comments · Fixed by #14794
Closed

Figure out domain parameter in PPI #14083

maririos opened this issue Aug 10, 2020 · 4 comments · Fixed by #14794
Assignees
@maririos
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Milestone
[2020] September

Comments

@maririos
Copy link
Member

PII brought a new parameter called domain. The main question is

  • how will the filter work?
  • what is the format?
  • will filters apply to other endpoints as well?
  • ...
@maririos maririos added Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics labels Aug 10, 2020
@maririos maririos added this to the [2020] September milestone Aug 10, 2020
@maririos
Copy link
Member Author

will filters apply to other endpoints as well?

Very likely for NER. Other domains will be added in the future like i.e. finance

@maririos maririos mentioned this issue Aug 21, 2020
Closed
@maririos
Copy link
Member Author

maririos commented Aug 26, 2020 •
edited
Loading

Currently considering making a EntityDomainType enum and having PHI on it.
It will be included into the options bag of PII and the name of the parameter will be domain

@maririos maririos self-assigned this Aug 26, 2020
@maririos
Copy link
Member Author

Should the enum be flags enum? or extensible enum?
Asking if the user can ask for more than one domain at a time...

@maririos maririos added the blocking-release Blocks release label Aug 27, 2020
@maririos
Copy link
Member Author

Will leave it as enum. Because it is input, then adding new domains will bump the version of the API.
If the user wants to ask for more than one domain at a time, it will need to do multiple requests, so no need for the flags enum.

@maririos maririos mentioned this issue Sep 2, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maririos maririos

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Milestone
[2020] September
Development

Successfully merging a pull request may close this issue.

[TA] Add PII back maririos/azure-sdk-for-net
1 participant
@maririos