[EngSys] Builds not failing if dependencies changed but no "rush update" #9243
Labels
Central-EngSys
This issue is owned by the Engineering System team.
Client
This issue points to a problem in the data-plane of the library.
EngSys
This issue is impacting the engineering system.
A couple PRs in the last week changed dependencies but
rush update
was not run (there were no changes topnpm-lock.yaml
). A recent example is #9082.What's unexpected is the validation builds for this PR passed. I thought the build should fail if
pnpm-lock.yaml
does not match the deps in all thepackage.json
files. I thoughtrush install
should always fail in this case, but even if not then the build or tests should fail since the deps would be missing.Assuming this would have caused a build break in the past, two possible explanations:
rush
, orpnpm
which prevents this from breaking the build.The text was updated successfully, but these errors were encountered: