Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngSys] Builds not failing if dependencies changed but no "rush update" #9243

Closed
mikeharder opened this issue Jun 2, 2020 · 1 comment
Closed
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@mikeharder
Copy link
Member

A couple PRs in the last week changed dependencies but rush update was not run (there were no changes to pnpm-lock.yaml). A recent example is #9082.

What's unexpected is the validation builds for this PR passed. I thought the build should fail if pnpm-lock.yaml does not match the deps in all the package.json files. I thought rush install should always fail in this case, but even if not then the build or tests should fail since the deps would be missing.

Assuming this would have caused a build break in the past, two possible explanations:

  1. Something changed in our pipelines, rush, or pnpm which prevents this from breaking the build.
  2. It only causes a build break in certain cases, say if a dependency version is updated or a totally new dependency is added. But if all the dependencies are already used by other packages, it doesn't cause any failures.
@mikeharder mikeharder added the EngSys This issue is impacting the engineering system. label Jun 2, 2020
@mikeharder mikeharder added the Client This issue points to a problem in the data-plane of the library. label Jun 2, 2020
@mikeharder mikeharder changed the title [engsys] Builds not failing if dependencies changed but no "rush update" [EngSys] Builds not failing if dependencies changed but no "rush update" Jun 2, 2020
@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Sep 22, 2020
@mikeharder
Copy link
Member Author

Dup of #11789

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team. Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

3 participants