diff --git a/sdk/communication/azure-communication-sms/pom.xml b/sdk/communication/azure-communication-sms/pom.xml index a725d84a808ec..7007b93f9e7aa 100644 --- a/sdk/communication/azure-communication-sms/pom.xml +++ b/sdk/communication/azure-communication-sms/pom.xml @@ -45,22 +45,6 @@ 0.75 - - - - org.jacoco - jacoco-maven-plugin - 0.8.5 - - - 0.75 - 0.75 - - - - - - com.azure diff --git a/sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsLiveAsyncClientTests.java b/sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsLiveAsyncClientTests.java index 7cd0cbeb23f7e..2f3e0395f8571 100644 --- a/sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsLiveAsyncClientTests.java +++ b/sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsLiveAsyncClientTests.java @@ -76,7 +76,7 @@ public void sendSmsRequestAsyncSingleNumberNoDeliveryReport(HttpClient httpClien } private SmsAsyncClient getTestSmsClient(HttpClient httpClient) { - return getSmsClientBuilder(httpClient) + return getSmsClientBuilderWithConnectionString(httpClient) .buildAsyncClient(); } } diff --git a/sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsLiveClientTests.java b/sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsLiveClientTests.java index 1cf97cdc6fb9d..743f795a281a4 100644 --- a/sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsLiveClientTests.java +++ b/sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsLiveClientTests.java @@ -126,7 +126,7 @@ public void sendSmsRequestMalformedNumber(HttpClient httpClient) throws NoSuchAl private SmsClient getTestSmsClient(HttpClient httpClient) { - return getSmsClientBuilder(httpClient) + return getSmsClientBuilderWithConnectionString(httpClient) .buildClient(); } } diff --git a/sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsLiveTestBase.java b/sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsLiveTestBase.java index 3fbcde526928d..d81dc10bae3ff 100644 --- a/sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsLiveTestBase.java +++ b/sdk/communication/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsLiveTestBase.java @@ -30,7 +30,7 @@ public class SmsLiveTestBase extends TestBase { .get("SMS_SERVICE_ENDPOINT", "https://REDACTED.communication.azure.com"); static final String CONNECTION_STRING = Configuration.getGlobalConfiguration() - .get("COMMUNICATION_CONNECTION_STRING", "endpoint=https://REDACTED.communication.azure.com/;accesskey=VGhpcyBpcyBhIHRlc3Q="); + .get("COMMUNICATION_LIVETEST_CONNECTION_STRING", "endpoint=https://REDACTED.communication.azure.com/;accesskey=VGhpcyBpcyBhIHRlc3Q="); protected SmsClientBuilder getSmsClientBuilder(HttpClient httpClient) { SmsClientBuilder builder = new SmsClientBuilder(); diff --git a/sdk/communication/tests.yml b/sdk/communication/tests.yml index a435579fb1403..8b57bf8685cc4 100644 --- a/sdk/communication/tests.yml +++ b/sdk/communication/tests.yml @@ -10,9 +10,18 @@ jobs: - name: azure-communication-chat groupId: com.azure safeName: azurecommunicationchat + - name: azure-communication-sms + groupId: com.azure + safeName: azurecommunicationsms ServiceDirectory: communication EnvVars: AZURE_TEST_MODE: LIVE SKIP_PHONENUMBER_INTEGRATION_TESTS: TRUE SKIP_LIVE_TEST: TRUE + AZURE_SUBSCRIPTION_ID: $(acs-subscription-id) + COMMUNICATION_LIVETEST_CONNECTION_STRING: $(communication-livetest-connection-string) + SMS_SERVICE_PHONE_NUMBER: $(communication-livetest-phone-number) + AZURE_TENANT_ID: $(aad-azure-sdk-test-tenant-id) + AZURE_CLIENT_SECRET: $(aad-azure-sdk-test-client-secret) + AZURE_CLIENT_ID: $(aad-azure-sdk-test-client-id)