Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Support Additional Body Types in HttpRequest #19025

Closed
2 tasks done
alzimmermsft opened this issue Feb 5, 2021 · 1 comment
Closed
2 tasks done

Investigate Support Additional Body Types in HttpRequest #19025

alzimmermsft opened this issue Feb 5, 2021 · 1 comment
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. HttpClient pillar-performance The issue is related to performance, one of our core engineering pillars.

Comments

@alzimmermsft
Copy link
Member

alzimmermsft commented Feb 5, 2021

We should investigate supporting additional body types in HttpRequest which will allow for performance optimizations such as no copy sends. The following should take priority:

  • InputStream: APIs accepting InputSteam will convert it into Flux<ByteBuffer> using buffering logic.
  • File: APIs accepting File, or String filePath, will convert it into Flux<ByteBuffer> by reading the file into memory.
@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core HttpClient pillar-performance The issue is related to performance, one of our core engineering pillars. labels Feb 5, 2021
@alzimmermsft
Copy link
Member Author

Resolved by #22829

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. HttpClient pillar-performance The issue is related to performance, one of our core engineering pillars.
Projects
None yet
Development

No branches or pull requests

1 participant