Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Flux<ByteBuffer> Backed Stream Implementations #11676

Closed
alzimmermsft opened this issue Jun 2, 2020 · 1 comment
Closed

Add a Flux<ByteBuffer> Backed Stream Implementations #11676

alzimmermsft opened this issue Jun 2, 2020 · 1 comment
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. design-discussion An area of design currently under discussion and open to team and community feedback. feature-request This issue requires a new behavior in the product in order be resolved. pillar-performance The issue is related to performance, one of our core engineering pillars.
Milestone
Backlog

Comments

@alzimmermsft
Copy link
Member

Many serialization libraries allow for streams to be passed in addition to byte[] and String. Our network responses are presented as Flux<ByteBuffer> which doesn't work with these APIs. We should look into adding InputStream and OutputStream implementations which are backed by a Flux<ByteBuffer to allow for lazy reading during serialization and deserialization.
@alzimmermsft alzimmermsft added Azure.Core azure-core feature-request This issue requires a new behavior in the product in order be resolved. labels Jun 2, 2020
@alzimmermsft alzimmermsft added the design-discussion An area of design currently under discussion and open to team and community feedback. label Jul 15, 2020
@alzimmermsft alzimmermsft mentioned this issue Jul 15, 2020
Closed
4 tasks
@alzimmermsft alzimmermsft added the Client This issue points to a problem in the data-plane of the library. label Jul 15, 2020
@alzimmermsft alzimmermsft added this to the [2020] September milestone Jul 22, 2020
@alzimmermsft alzimmermsft modified the milestones: [2020] September, Backlog Oct 8, 2020
@alzimmermsft alzimmermsft added the pillar-performance The issue is related to performance, one of our core engineering pillars. label Jan 19, 2021
@alzimmermsft alzimmermsft mentioned this issue Feb 17, 2021
Closed
15 tasks
@alzimmermsft alzimmermsft removed their assignment Aug 3, 2021
@alzimmermsft
Copy link
Member Author

Closing as won't be done until there is more need for this. We're moving away from Flux<ByteBuffer> being the only way to represent the request and response body to allowing more representations, making this change less useful.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. design-discussion An area of design currently under discussion and open to team and community feedback. feature-request This issue requires a new behavior in the product in order be resolved. pillar-performance The issue is related to performance, one of our core engineering pillars.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@alzimmermsft