Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve enum names for . values #2904

Closed
jhendrixMSFT opened this issue Oct 4, 2018 · 2 comments
Closed

Improve enum names for . values #2904

jhendrixMSFT opened this issue Oct 4, 2018 · 2 comments
Assignees
@vladbarosan
Labels
CodeGen Issues that relate to code generation

Comments

@jhendrixMSFT
Copy link
Member

Found while investigating PR Azure/azure-rest-api-specs#4016

This PR contains a discriminator value Microsoft.Azure.Monitor.MultipleResourceMultipleMetricCriteria which the generator changes to MicrosoftAzureMonitorMultipleResourceMultipleMetricCriteria for the enum name and value. The removal of the . from the enum value is problematic as it doesn't match the value sent over the wire.
@jhendrixMSFT jhendrixMSFT added the CodeGen Issues that relate to code generation label Oct 4, 2018
@jhendrixMSFT
Copy link
Member Author

On further investigation the values are correct (i.e. the . isn't being removed) however the names are just terrible and should be shortened.

@vladbarosan vladbarosan changed the title Discriminator values that contain . characters have them removed during naming Improve enum names for . values Oct 4, 2018
@vladbarosan
Copy link

After investigating, this would bring breaking changes and also wouldn't be safe for a couple of discriminator values. Closing for now.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vladbarosan vladbarosan

Labels
CodeGen Issues that relate to code generation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhendrixMSFT @vladbarosan