Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide 2019-10-01 version of consumption APIs #12452

Closed
narph opened this issue Sep 9, 2020 · 11 comments
Closed

Provide 2019-10-01 version of consumption APIs #12452

narph opened this issue Sep 9, 2020 · 11 comments
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library. Previous Versions Work related to track1 and track1.5 SDKs

Comments

@narph
Copy link

narph commented Sep 9, 2020

Feature Request

Atm, we see the /consumption/mgmt api calls are mapped up to 2019-01-01 https://github.com/Azure/azure-sdk-for-go/tree/master/services/consumption/mgmt.
With 2019-10-01 new improvements were added as supporting more subscription types.
Any idea when we can see this version in the sdk?

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Sep 9, 2020
@ArcturusZhang ArcturusZhang added feature-request This issue requires a new behavior in the product in order be resolved. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Sep 10, 2020
@ArcturusZhang
Copy link
Member

Hi @narph thanks for this issue!

We will release this API version in the next minor version after this PR is merged. Thanks

@vijayrajah
Copy link

@ArcturusZhang .. I see the PR was merged.. Any idea when this will be released?

@ArcturusZhang
Copy link
Member

@ArcturusZhang .. I see the PR was merged.. Any idea when this will be released?

Yeah, the PR has been merged. But we have to ask the corresponding service team to see if they want to release the SDK for a new api-version. Usually they will release this, but we have to confirm whether there is anything wrong in the current swagger before we could release this. Please stay tuned and sorry for the delay.

@vijayrajah
Copy link

@ArcturusZhang . Thanks for the update.. Appreciate it

@mrsheepuk
Copy link

mrsheepuk commented Nov 25, 2020

Any update on when this is likely to be released? At the current version, as far as I can work out, it's impossible to filter by usage date for anything other than EA accounts...

@mrsheepuk
Copy link

@ArcturusZhang FYI, I tested the consumption API on this PR #13208 and got errors unmarshalling JSON due to being unable to parse the values in the JSON for IsAzureCreditEligible on ModernUsageDetailProperties - the JSON has a value of "1" for this and the model defines it as a *bool - changing it in the model to *string let me get past the error and carry on. I don't believe the go JSON marshaller accepts the string value "1" as a bool when parsing JSON.

I also note that the startDate and endDate parameters are not available on UsageDetailsClient.List() - adding these in by hand, they do work, but I note those are missing from the swagger specs so I'm guessing that problem lies elsewhere.

If there are better places/ways to raise these issues, please let me know and I'll raise them appropriately.

@ArcturusZhang
Copy link
Member

Hi @mrsheepuk instead of changing the SDK, I suppose this is more of a problem that the service should not return a boolean value in string - it is a better solution if the service team could change their payload.
Could you please open an issue in the azure-rest-api-specs repo about this?

@mrsheepuk
Copy link

Thanks @ArcturusZhang - raised Azure/azure-rest-api-specs#11849 for this.

@ArcturusZhang
Copy link
Member

Thanks @ArcturusZhang - raised Azure/azure-rest-api-specs#11849 for this.

Thanks! And I have labeled the issue to draw service team's attention.

@RickWinter RickWinter added this to the Backlog milestone Jul 12, 2021
@adhiraj-g
Copy link

Hi There,

Any update on when the 2019-10-01 version of consumption APIs would likely be available for Azure module billing metricset?

@RickWinter RickWinter added Mgmt This issue is related to a management-plane library. Previous Versions Work related to track1 and track1.5 SDKs labels Sep 13, 2021
@lirenhe
Copy link
Member

lirenhe commented Sep 28, 2021

From Azure/azure-rest-api-specs#11849, I believe the issue was fixed from service side. Close this item and please let me know if you have other asks.

@lirenhe lirenhe closed this as completed Sep 28, 2021
@RickWinter RickWinter modified the milestones: Backlog, [2021] October Dec 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library. Previous Versions Work related to track1 and track1.5 SDKs
Projects
None yet
Development

No branches or pull requests

7 participants