Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly generate latest profile #1066

Closed
vladbarosan opened this issue Feb 8, 2018 · 6 comments
Closed

Properly generate latest profile #1066

vladbarosan opened this issue Feb 8, 2018 · 6 comments
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved.
Milestone

Comments

@vladbarosan
Copy link

Fix remaining from #1054

Currently the latest profile is not generated respecting the stable/preview folder stucture of the rest specs api.

@vladbarosan vladbarosan added this to the v14.0.0 (GA) milestone Feb 8, 2018
@vladbarosan vladbarosan added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Feb 8, 2018
@marstr
Copy link
Member

marstr commented Feb 13, 2018

To elaborate, in order to fix this, I'm writing two command-line utilities:

  1. A tool that inspects the specs repository, to find all "preview" and "stable" README and their tags.
  2. A tool that determines the Go package names from a list of Azure REST API Spec READMEs and tags.

This modular approach will still sit behind go generate so no extra complexity should be exposed to the end users. However, this is also necessary functionality for the Swagger -> SDK tooling. I've chatted with @lmazuel this morning to make sure that tool 1 fits the Swagger -> SDK needs.

@vladbarosan
Copy link
Author

vladbarosan commented Feb 13, 2018

@marstr I think both of does are being done in the generator, you can pull them from there. Otherwise sounds good decoupling the first one from the generator.

@marstr
Copy link
Member

marstr commented Feb 13, 2018

I'll make sure to checkout the generator, to make sure I'm not duplicating any code.

@marstr
Copy link
Member

marstr commented Mar 5, 2018

Part 1 of this is done (albeit with some polish missing.) For now, the code can be found here: https://github.com/marstr/az-rest-spec-finder

@marstr
Copy link
Member

marstr commented Nov 12, 2018

Putting this back in the triage bucket

@jhendrixMSFT jhendrixMSFT mentioned this issue Dec 14, 2018
6 tasks
@jhendrixMSFT
Copy link
Member

Fixed in latest, will ship in v24.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved.
Projects
None yet
Development

No branches or pull requests

3 participants