Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-evaluate if it is better for the current depth field to be exposed from az_json_reader or az_json_token #1808

Closed
ahsonkhan opened this issue Jun 30, 2021 · 1 comment
Closed

Re-evaluate if it is better for the current depth field to be exposed from az_json_reader or az_json_token #1808

ahsonkhan opened this issue Jun 30, 2021 · 1 comment
Labels
Azure.Core blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. design-discussion An area of design currently under discussion and open to team and community feedback.
Milestone
[2021] September

Comments

@ahsonkhan
Copy link
Contributor

Follow-up from #1802
@ahsonkhan ahsonkhan added this to the [2021] August milestone Jun 30, 2021
@ahsonkhan ahsonkhan self-assigned this Jun 30, 2021
@ahsonkhan ahsonkhan mentioned this issue Jun 30, 2021
Merged
@RickWinter RickWinter added the Client This issue points to a problem in the data-plane of the library. label Jul 7, 2021
@RickWinter RickWinter added design-discussion An area of design currently under discussion and open to team and community feedback. and removed Design labels Aug 2, 2021
@RickWinter RickWinter modified the milestones: [2021] September, Backlog Aug 4, 2021
@ahsonkhan ahsonkhan modified the milestones: Backlog, [2021] September Aug 27, 2021
@ahsonkhan ahsonkhan added the blocking-release Blocks release label Aug 27, 2021
@ahsonkhan
Copy link
Contributor Author

Based on offline discussion with @JeffreyRichter, leaving the current_depth field within the az_json_reader top-level struct makes sense. In the future, we could add a depth field within the az_json_token struct, if needed, which would point to the same value.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Azure.Core blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. design-discussion An area of design currently under discussion and open to team and community feedback.
Projects
None yet
Milestone
[2021] September
Development

No branches or pull requests
2 participants
@RickWinter @ahsonkhan