From b91c1b045f5e525e314f9ff0f926e01d1548dd8f Mon Sep 17 00:00:00 2001 From: Manchit Gupta Date: Fri, 8 Mar 2019 11:45:07 -0800 Subject: [PATCH 1/5] Patch call for DDoS Protection plan Removing unreferenced definition Addressing review comments. Setting x-ms-long-running-operation to false Removing tags from Patch call description Fixing the response message description Removing x-ms-long-running-operation from patch fixing the file renames --- .../stable/2018-11-01/ddosProtectionPlan.json | 51 +++++++++++++++++++ .../examples/DdosProtectionPlanUpdate.json | 33 ++++++++++++ .../stable/2018-12-01/ddosProtectionPlan.json | 51 +++++++++++++++++++ .../examples/DdosProtectionPlanUpdate.json | 33 ++++++++++++ 4 files changed, 168 insertions(+) create mode 100644 specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdate.json create mode 100644 specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdate.json diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json index b20425a6aad6..8e9bc233d5ce 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json @@ -180,6 +180,57 @@ "$ref": "./examples/DdosProtectionPlanCreate.json" } } + }, + "patch": { + "tags": [ + "DdosProtectionPlans" + ], + "operationId": "DdosProtectionPlans_Update", + "description": "Update a DDoS protection plan", + "parameters": [ + { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group." + }, + { + "name": "ddosProtectionPlanName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the DDoS protection plan." + }, + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "./network.json#/definitions/TagsObject" + }, + "description": "Parameters supplied to the update DDoS protection plan resource." + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "200": { + "description": "Update successful.", + "schema": { + "$ref": "#/definitions/DdosProtectionPlan" + } + } + }, + "x-ms-examples": { + "DDoS protection plan Update tags": { + "$ref": "./examples/DdosProtectionPlanUpdate.json" + } + } } }, "/subscriptions/{subscriptionId}/providers/Microsoft.Network/ddosProtectionPlans": { diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdate.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdate.json new file mode 100644 index 000000000000..f996a336c528 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdate.json @@ -0,0 +1,33 @@ +{ + "parameters": { + "api-version": "2018-11-01", + "subscriptionId": "subid", + "resourceGroupName": "rg1", + "ddosProtectionPlanName": "test-plan", + "parameters": { + "tags": { + "tag1": "value1", + "tag2": "value2" + } + } + }, + "responses": { + "200": { + "body": { + "name": "test-plan", + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/ddosProtectionPlans/test-plan", + "type": "Microsoft.Network/ddosProtectionPlans", + "location": "westus", + "tags": { + "tag1": "value1", + "tag2": "value2" + }, + "properties": { + "provisioningState": "Succeeded", + "resourceGuid": "00000000-0000-0000-0000-000000000000", + "virtualNetworks": [] + } + } + } + } +} diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json index 7ebc2a166b60..727d8c90d88e 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json @@ -180,6 +180,57 @@ "$ref": "./examples/DdosProtectionPlanCreate.json" } } + }, + "patch": { + "tags": [ + "DdosProtectionPlans" + ], + "operationId": "DdosProtectionPlans_Update", + "description": "Update a DDoS protection plan", + "parameters": [ + { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group." + }, + { + "name": "ddosProtectionPlanName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the DDoS protection plan." + }, + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "./network.json#/definitions/TagsObject" + }, + "description": "Parameters supplied to the update DDoS protection plan resource." + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "200": { + "description": "Update successful.", + "schema": { + "$ref": "#/definitions/DdosProtectionPlan" + } + } + }, + "x-ms-examples": { + "DDoS protection plan Update tags": { + "$ref": "./examples/DdosProtectionPlanUpdate.json" + } + } } }, "/subscriptions/{subscriptionId}/providers/Microsoft.Network/ddosProtectionPlans": { diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdate.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdate.json new file mode 100644 index 000000000000..499288163fa0 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdate.json @@ -0,0 +1,33 @@ +{ + "parameters": { + "api-version": "2018-12-01", + "subscriptionId": "subid", + "resourceGroupName": "rg1", + "ddosProtectionPlanName": "test-plan", + "parameters": { + "tags": { + "tag1": "value1", + "tag2": "value2" + } + } + }, + "responses": { + "200": { + "body": { + "name": "test-plan", + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/ddosProtectionPlans/test-plan", + "type": "Microsoft.Network/ddosProtectionPlans", + "location": "westus", + "tags": { + "tag1": "value1", + "tag2": "value2" + }, + "properties": { + "provisioningState": "Succeeded", + "resourceGuid": "00000000-0000-0000-0000-000000000000", + "virtualNetworks": [] + } + } + } + } +} From 640f220747199a2b32a823b66a040bf8269a284b Mon Sep 17 00:00:00 2001 From: Manchit Gupta Date: Tue, 19 Mar 2019 12:15:18 -0700 Subject: [PATCH 2/5] Adding patch call to 2019-02-01 --- .../stable/2018-11-01/ddosProtectionPlan.json | 3 +- .../stable/2018-12-01/ddosProtectionPlan.json | 3 +- .../stable/2019-02-01/ddosProtectionPlan.json | 53 +++++++++++++++++++ .../examples/DdosProtectionPlanUpdate.json | 33 ++++++++++++ 4 files changed, 90 insertions(+), 2 deletions(-) create mode 100644 specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/DdosProtectionPlanUpdate.json diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json index 8e9bc233d5ce..355b4387103e 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json @@ -226,8 +226,9 @@ } } }, + "x-ms-long-running-operation": true, "x-ms-examples": { - "DDoS protection plan Update tags": { + "DDoS protection plan Update": { "$ref": "./examples/DdosProtectionPlanUpdate.json" } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json index 727d8c90d88e..0da8fdd76c6f 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json @@ -226,8 +226,9 @@ } } }, + "x-ms-long-running-operation": true, "x-ms-examples": { - "DDoS protection plan Update tags": { + "DDoS protection plan Update": { "$ref": "./examples/DdosProtectionPlanUpdate.json" } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json index a6e06eecf4b6..1f2c4396ba7f 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json @@ -180,7 +180,60 @@ "$ref": "./examples/DdosProtectionPlanCreate.json" } } + }, + "patch": { + "tags": [ + "DdosProtectionPlans" + ], + "operationId": "DdosProtectionPlans_Update", + "description": "Update a DDoS protection plan", + "parameters": [ + { + "name": "resourceGroupName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the resource group." + }, + { + "name": "ddosProtectionPlanName", + "in": "path", + "required": true, + "type": "string", + "description": "The name of the DDoS protection plan." + }, + { + "name": "parameters", + "in": "body", + "required": true, + "schema": { + "$ref": "./network.json#/definitions/TagsObject" + }, + "description": "Parameters supplied to the update DDoS protection plan resource." + }, + { + "$ref": "./network.json#/parameters/ApiVersionParameter" + }, + { + "$ref": "./network.json#/parameters/SubscriptionIdParameter" + } + ], + "responses": { + "200": { + "description": "Update successful.", + "schema": { + "$ref": "#/definitions/DdosProtectionPlan" + } + } + }, + "x-ms-long-running-operation": true, + "x-ms-examples": { + "DDoS protection plan Update": { + "$ref": "./examples/DdosProtectionPlanUpdate.json" + } + } } + } }, "/subscriptions/{subscriptionId}/providers/Microsoft.Network/ddosProtectionPlans": { "get": { diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/DdosProtectionPlanUpdate.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/DdosProtectionPlanUpdate.json new file mode 100644 index 000000000000..499288163fa0 --- /dev/null +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/DdosProtectionPlanUpdate.json @@ -0,0 +1,33 @@ +{ + "parameters": { + "api-version": "2018-12-01", + "subscriptionId": "subid", + "resourceGroupName": "rg1", + "ddosProtectionPlanName": "test-plan", + "parameters": { + "tags": { + "tag1": "value1", + "tag2": "value2" + } + } + }, + "responses": { + "200": { + "body": { + "name": "test-plan", + "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/ddosProtectionPlans/test-plan", + "type": "Microsoft.Network/ddosProtectionPlans", + "location": "westus", + "tags": { + "tag1": "value1", + "tag2": "value2" + }, + "properties": { + "provisioningState": "Succeeded", + "resourceGuid": "00000000-0000-0000-0000-000000000000", + "virtualNetworks": [] + } + } + } + } +} From 911850b6356828aa6f248d69346bb118f81a2554 Mon Sep 17 00:00:00 2001 From: Manchit Gupta Date: Tue, 19 Mar 2019 12:18:58 -0700 Subject: [PATCH 3/5] fixing date --- .../stable/2019-02-01/examples/DdosProtectionPlanUpdate.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/DdosProtectionPlanUpdate.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/DdosProtectionPlanUpdate.json index 499288163fa0..624c00a035a4 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/DdosProtectionPlanUpdate.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/DdosProtectionPlanUpdate.json @@ -1,6 +1,6 @@ { "parameters": { - "api-version": "2018-12-01", + "api-version": "2019-02-01", "subscriptionId": "subid", "resourceGroupName": "rg1", "ddosProtectionPlanName": "test-plan", From 99795285eb998c0636642310e3d5eeefbc11081d Mon Sep 17 00:00:00 2001 From: Manchit Gupta Date: Tue, 19 Mar 2019 12:24:43 -0700 Subject: [PATCH 4/5] fixing semantic error --- .../Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json | 1 - 1 file changed, 1 deletion(-) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json index 1f2c4396ba7f..6334cac08aab 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json @@ -233,7 +233,6 @@ } } } - } }, "/subscriptions/{subscriptionId}/providers/Microsoft.Network/ddosProtectionPlans": { "get": { From 6bf97babcf2f5b8706345d4db6ab8ab76621104d Mon Sep 17 00:00:00 2001 From: Manchit Gupta Date: Thu, 21 Mar 2019 11:22:49 -0700 Subject: [PATCH 5/5] Addressing review comments --- .../stable/2018-11-01/ddosProtectionPlan.json | 12 ++++++------ ...Update.json => DdosProtectionPlanUpdateTags.json} | 0 .../stable/2018-12-01/ddosProtectionPlan.json | 12 ++++++------ ...Update.json => DdosProtectionPlanUpdateTags.json} | 0 .../stable/2019-02-01/ddosProtectionPlan.json | 12 ++++++------ ...Update.json => DdosProtectionPlanUpdateTags.json} | 0 6 files changed, 18 insertions(+), 18 deletions(-) rename specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/{DdosProtectionPlanUpdate.json => DdosProtectionPlanUpdateTags.json} (100%) rename specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/{DdosProtectionPlanUpdate.json => DdosProtectionPlanUpdateTags.json} (100%) rename specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/{DdosProtectionPlanUpdate.json => DdosProtectionPlanUpdateTags.json} (100%) diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json index 355b4387103e..1e25bc323241 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/ddosProtectionPlan.json @@ -185,8 +185,8 @@ "tags": [ "DdosProtectionPlans" ], - "operationId": "DdosProtectionPlans_Update", - "description": "Update a DDoS protection plan", + "operationId": "DdosProtectionPlans_UpdateTags", + "description": "Update a DDoS protection plan tags", "parameters": [ { "name": "resourceGroupName", @@ -209,7 +209,7 @@ "schema": { "$ref": "./network.json#/definitions/TagsObject" }, - "description": "Parameters supplied to the update DDoS protection plan resource." + "description": "Parameters supplied to the update DDoS protection plan resource tags." }, { "$ref": "./network.json#/parameters/ApiVersionParameter" @@ -220,7 +220,7 @@ ], "responses": { "200": { - "description": "Update successful.", + "description": "Update successful. The operation returns the resulting DDoS protection plan resource.", "schema": { "$ref": "#/definitions/DdosProtectionPlan" } @@ -228,8 +228,8 @@ }, "x-ms-long-running-operation": true, "x-ms-examples": { - "DDoS protection plan Update": { - "$ref": "./examples/DdosProtectionPlanUpdate.json" + "DDoS protection plan Update tags": { + "$ref": "./examples/DdosProtectionPlanUpdateTags.json" } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdate.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdateTags.json similarity index 100% rename from specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdate.json rename to specification/network/resource-manager/Microsoft.Network/stable/2018-11-01/examples/DdosProtectionPlanUpdateTags.json diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json index 0da8fdd76c6f..67cb1306802b 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/ddosProtectionPlan.json @@ -185,8 +185,8 @@ "tags": [ "DdosProtectionPlans" ], - "operationId": "DdosProtectionPlans_Update", - "description": "Update a DDoS protection plan", + "operationId": "DdosProtectionPlans_UpdateTags", + "description": "Update a DDoS protection plan tags", "parameters": [ { "name": "resourceGroupName", @@ -209,7 +209,7 @@ "schema": { "$ref": "./network.json#/definitions/TagsObject" }, - "description": "Parameters supplied to the update DDoS protection plan resource." + "description": "Parameters supplied to the update DDoS protection plan resource tags." }, { "$ref": "./network.json#/parameters/ApiVersionParameter" @@ -220,7 +220,7 @@ ], "responses": { "200": { - "description": "Update successful.", + "description": "Update successful. The operation returns the resulting DDoS protection plan resource.", "schema": { "$ref": "#/definitions/DdosProtectionPlan" } @@ -228,8 +228,8 @@ }, "x-ms-long-running-operation": true, "x-ms-examples": { - "DDoS protection plan Update": { - "$ref": "./examples/DdosProtectionPlanUpdate.json" + "DDoS protection plan Update tags": { + "$ref": "./examples/DdosProtectionPlanUpdateTags.json" } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdate.json b/specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdateTags.json similarity index 100% rename from specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdate.json rename to specification/network/resource-manager/Microsoft.Network/stable/2018-12-01/examples/DdosProtectionPlanUpdateTags.json diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json index 6334cac08aab..cfc6a9887e67 100644 --- a/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json +++ b/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/ddosProtectionPlan.json @@ -185,8 +185,8 @@ "tags": [ "DdosProtectionPlans" ], - "operationId": "DdosProtectionPlans_Update", - "description": "Update a DDoS protection plan", + "operationId": "DdosProtectionPlans_UpdateTags", + "description": "Update a DDoS protection plan tags", "parameters": [ { "name": "resourceGroupName", @@ -209,7 +209,7 @@ "schema": { "$ref": "./network.json#/definitions/TagsObject" }, - "description": "Parameters supplied to the update DDoS protection plan resource." + "description": "Parameters supplied to the update DDoS protection plan resource tags." }, { "$ref": "./network.json#/parameters/ApiVersionParameter" @@ -220,7 +220,7 @@ ], "responses": { "200": { - "description": "Update successful.", + "description": "Update successful. The operation returns the resulting DDoS protection plan resource.", "schema": { "$ref": "#/definitions/DdosProtectionPlan" } @@ -228,8 +228,8 @@ }, "x-ms-long-running-operation": true, "x-ms-examples": { - "DDoS protection plan Update": { - "$ref": "./examples/DdosProtectionPlanUpdate.json" + "DDoS protection plan Update tags": { + "$ref": "./examples/DdosProtectionPlanUpdateTags.json" } } } diff --git a/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/DdosProtectionPlanUpdate.json b/specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/DdosProtectionPlanUpdateTags.json similarity index 100% rename from specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/DdosProtectionPlanUpdate.json rename to specification/network/resource-manager/Microsoft.Network/stable/2019-02-01/examples/DdosProtectionPlanUpdateTags.json