From a9ff5f330e569cbbdfded62d6506e9fe2b71f9ae Mon Sep 17 00:00:00 2001 From: Xian Du Date: Thu, 4 Oct 2018 11:01:05 -0700 Subject: [PATCH 1/3] Added identity to registry properties --- .../stable/2017-10-01/containerregistry.json | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json index 93b2ae0f7b12..dbb481306784 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json @@ -1387,6 +1387,10 @@ "$ref": "#/definitions/Sku", "description": "The SKU of the container registry." }, + "identity": { + "$ref": "#/definitions/RegistryIdentity", + "description": "The Identity of the container registry." + }, "properties": { "$ref": "#/definitions/RegistryProperties", "description": "The properties of the container registry.", @@ -1432,6 +1436,24 @@ } } }, + "RegistryIdentity": { + "description": "The Identity of the container registry.", + "type": "object", + "properties": { + "type": { + "description": "The type of identity used for the registry.", + "type": "string" + }, + "principalId": { + "description": "The principal id of registry identity.", + "type": "string" + }, + "tenantId": { + "description": "The tenant id associated with the registry.", + "type": "string" + } + } + }, "RegistryProperties": { "description": "The properties of a container registry.", "type": "object", @@ -1530,6 +1552,10 @@ "$ref": "#/definitions/Sku", "description": "The SKU of the container registry." }, + "identity": { + "$ref": "#/definitions/RegistryIdentity", + "description": "The Identity of the container registry." + }, "properties": { "$ref": "#/definitions/RegistryPropertiesUpdateParameters", "description": "The properties that the container registry will be updated with.", From 454d0e161ff250d2b0d4301d8375d74487249f30 Mon Sep 17 00:00:00 2001 From: Xian Du Date: Fri, 5 Oct 2018 16:01:36 -0700 Subject: [PATCH 2/3] CR comments --- .../stable/2017-10-01/containerregistry.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json index dbb481306784..7f7409696c15 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json @@ -1389,7 +1389,7 @@ }, "identity": { "$ref": "#/definitions/RegistryIdentity", - "description": "The Identity of the container registry." + "description": "The identity of the container registry." }, "properties": { "$ref": "#/definitions/RegistryProperties", @@ -1437,7 +1437,7 @@ } }, "RegistryIdentity": { - "description": "The Identity of the container registry.", + "description": "The identity of the container registry.", "type": "object", "properties": { "type": { @@ -1445,11 +1445,11 @@ "type": "string" }, "principalId": { - "description": "The principal id of registry identity.", + "description": "The principal ID of registry identity.", "type": "string" }, "tenantId": { - "description": "The tenant id associated with the registry.", + "description": "The tenant ID associated with the registry.", "type": "string" } } From 185e2e930d7cd67eb43fee8264dd52b805f87ec0 Mon Sep 17 00:00:00 2001 From: Xian Du Date: Fri, 5 Oct 2018 17:01:04 -0700 Subject: [PATCH 3/3] CR comments --- .../stable/2017-10-01/containerregistry.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json index 7f7409696c15..1e11c6793626 100644 --- a/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json +++ b/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json @@ -1554,7 +1554,7 @@ }, "identity": { "$ref": "#/definitions/RegistryIdentity", - "description": "The Identity of the container registry." + "description": "The identity of the container registry." }, "properties": { "$ref": "#/definitions/RegistryPropertiesUpdateParameters",