Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Converting Authoring Analyzeconversations of 2023-04-15-preview and 2023-04-01 version to Typespec. #30499

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

amber-ccc
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Copy link

openapi-pipeline-app bot commented Sep 10, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Sep 10, 2024

@microsoft-github-policy-service microsoft-github-policy-service bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. Cognitive Services labels Sep 10, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added data-plane TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Sep 10, 2024
@quentinRobinson quentinRobinson added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Sep 18, 2024
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@amber-ccc amber-ccc force-pushed the amber/converting-authoring-conversations-preview-GA branch from c17369b to 17b4469 Compare September 26, 2024 18:02
"$ref": "#/parameters/Azure.Core.Foundations.ApiVersionParameter"
},
{
"name": "projectName",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should explicitly model and resume these parameter types in TypeSpec.

- used ResourceAction and LongRunningResourceAction for Resource ProjectMetaData (Operation authorize-copy and copy)
- compiled
- implemented Resource ProjectDeployment Template for getDeploymentsList
- compiled
- implemented CopyProjectJobState by ResourceRead
- compiled
…jectMetadata)

- used ResourceRead template for resource DeploymentJobState (Child of ProjectDeployment)
- compiled
- used ResourceRead Template for these JobState resource
- compiled
- used some resource template of TrainingJobState
- compiled
…tate to fix duplicated DeploymentJobState resource issue

- compiled
…tate as resource

- used ResourceRead template for thess two resources
- compiled
- added action("copy") for this
- compiled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Cognitive Services customer-reported Issues that are reported by GitHub users external to the Azure organization. data-plane PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants