-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new NSP API versions #26154
Add new NSP API versions #26154
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
network.json | 2023-07-01-preview(450c83f) | 2023-05-01(main) |
network.json | 2023-07-01-preview(450c83f) | 2022-06-01-preview(main) |
networkSecurityPerimeter.json | 2023-07-01-preview(450c83f) | 2021-03-01-preview(main) |
network.json | 2023-08-01-preview(450c83f) | 2023-05-01(main) |
network.json | 2023-08-01-preview(450c83f) | 2022-06-01-preview(main) |
networkSecurityPerimeter.json | 2023-08-01-preview(450c83f) | 2021-03-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
LintDiff: 20 Errors, 32 Warnings failed [Detail]
compared tags (via openapi-validator v2.1.6) | new version | base version |
---|---|---|
package-2023-08-preview | package-2023-08-preview(450c83f) | default(main) |
package-2023-07-preview | package-2023-07-preview(450c83f) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/preview/2023-08-01-preview/networkSecurityPerimeter.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 2: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 3: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 4: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 5: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 6: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 7: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 8: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 9: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 10: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 11: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 12: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 13: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 14: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 15: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 16: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 17: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 18: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 19: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/450c83f8d0ed627e66f4ef0257f1f139970c5869/#L1 |
|
FATAL |
spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/network/resource-manager/Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 2: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 3: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 4: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 5: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 6: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 7: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 8: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 9: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 10: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 11: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 12: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 13: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 14: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 15: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 16: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 17: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 18: $[paths,'x-ms-paths']..^ threw: ErrorWithCause('Function 'resourceNameRestriction' threw an exception: Cannot read property 'in' of undefined') Error 19: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/450c83f8d0ed627e66f4ef0257f1f139970c5869/#L1 |
|
OperationsAPIImplementation |
Operations API must be implemented for 'Microsoft.Network'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L1 |
|
MissingTypeObject |
The schema 'ProxyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L171 |
|
RequiredPropertiesMissingInResourceModel |
Model definition 'NetworkSecurityPerimeter' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L1342 |
RPC-Get-V1-03, RPC-Put-V1-08 |
RequiredPropertiesMissingInResourceModel |
Model definition 'NspProfile' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L1427 |
RPC-Get-V1-03, RPC-Put-V1-08 |
TrackedResourcePatchOperation |
Tracked resource 'NspProfile' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L1427 |
RPC-Patch-V1-03 |
RequiredPropertiesMissingInResourceModel |
Model definition 'NspAccessRule' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L1490 |
RPC-Get-V1-03, RPC-Put-V1-08 |
TrackedResourcePatchOperation |
Tracked resource 'NspAccessRule' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L1490 |
RPC-Patch-V1-03 |
RequiredPropertiesMissingInResourceModel |
Model definition 'NspAssociation' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L1632 |
RPC-Get-V1-03, RPC-Put-V1-08 |
TrackedResourcePatchOperation |
Tracked resource 'NspAssociation' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L1632 |
RPC-Patch-V1-03 |
OperationsAPIImplementation |
Operations API must be implemented for 'Microsoft.Network'. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L1 |
|
MissingTypeObject |
The schema 'ProxyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L171 |
|
RequiredPropertiesMissingInResourceModel |
Model definition 'NetworkSecurityPerimeter' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/preview/2023-08-01-preview/networkSecurityPerimeter.json#L1342 |
RPC-Get-V1-03, RPC-Put-V1-08 |
RequiredPropertiesMissingInResourceModel |
Model definition 'NspProfile' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/preview/2023-08-01-preview/networkSecurityPerimeter.json#L1427 |
RPC-Get-V1-03, RPC-Put-V1-08 |
TrackedResourcePatchOperation |
Tracked resource 'NspProfile' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/preview/2023-08-01-preview/networkSecurityPerimeter.json#L1427 |
RPC-Patch-V1-03 |
RequiredPropertiesMissingInResourceModel |
Model definition 'NspAccessRule' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/preview/2023-08-01-preview/networkSecurityPerimeter.json#L1490 |
RPC-Get-V1-03, RPC-Put-V1-08 |
TrackedResourcePatchOperation |
Tracked resource 'NspAccessRule' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/preview/2023-08-01-preview/networkSecurityPerimeter.json#L1490 |
RPC-Patch-V1-03 |
RequiredPropertiesMissingInResourceModel |
Model definition 'NspAssociation' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Network/preview/2023-08-01-preview/networkSecurityPerimeter.json#L1639 |
RPC-Get-V1-03, RPC-Put-V1-08 |
TrackedResourcePatchOperation |
Tracked resource 'NspAssociation' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/preview/2023-08-01-preview/networkSecurityPerimeter.json#L1639 |
RPC-Patch-V1-03 |
The response of operation:'NetworkSecurityPerimeters_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L52 |
||
The response of operation:'NetworkSecurityPerimeters_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L78 |
||
The response of operation:'NetworkSecurityPerimeters_Patch' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L147 |
||
The response of operation:'NspProfiles_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L296 |
||
The response of operation:'NspProfiles_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L322 |
||
The response of operation:'NspAccessRules_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L464 |
||
The response of operation:'NspAccessRules_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L490 |
||
The response of operation:'NspAssociations_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L632 |
||
The response of operation:'NspAssociations_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L658 |
||
OperationId should contain the verb: 'reconcile' in:'NspAssociationReconcile_Post'. Consider updating the operationId Location: Microsoft.Network/preview/2023-07-01-preview/networkSecurityPerimeter.json#L811 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
MissingTypeObject |
The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L38 |
MissingTypeObject |
The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L55 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L69 |
MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L83 |
MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L93 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L108 |
MissingTypeObject |
The schema 'AzureAsyncOperationResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L118 |
MissingTypeObject |
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L140 |
MissingTypeObject |
The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L197 |
MissingTypeObject |
The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L207 |
MissingTypeObject |
The schema 'ManagedServiceIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L272 |
AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L300 |
ProvisioningStateValidation |
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L320 |
MissingTypeObject |
The schema 'ExtendedLocation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L394 |
XmsParameterLocation |
The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L409 |
XmsParameterLocation |
The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L416 |
XmsParameterLocation |
The parameter 'ApiVersionVmssParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.Network/preview/2023-07-01-preview/network.json#L423 |
MissingTypeObject |
The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L38 |
MissingTypeObject |
The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L55 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L69 |
MissingTypeObject |
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L83 |
MissingTypeObject |
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L93 |
XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L108 |
MissingTypeObject |
The schema 'AzureAsyncOperationResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L118 |
MissingTypeObject |
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L140 |
MissingTypeObject |
The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L197 |
MissingTypeObject |
The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L207 |
MissingTypeObject |
The schema 'ManagedServiceIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L272 |
AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L300 |
ProvisioningStateValidation |
ProvisioningState must have terminal states: Succeeded, Failed and Canceled. Location: Microsoft.Network/preview/2023-08-01-preview/network.json#L320 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Please address or respond to feedback from the ARM API reviewer. |
Hi @kaushal087! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
…into nsp_version
@Joanna-Yang-Art The LintDiff check is failing, it's not because of our code. The same error was coming in our previous PR (#24147) and it was approved. Could you please review and approve? Thanks. |
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReview
label.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.