Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jpeng/file sharing complete #23793

Merged
merged 4 commits into from
May 2, 2023
Merged

Jpeng/file sharing complete #23793

merged 4 commits into from
May 2, 2023

Conversation

jpeng-ms
Copy link
Member

@jpeng-ms jpeng-ms commented May 2, 2023

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-workflow-bot
Copy link

Hi, @jpeng-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 2, 2023 •
    edited
    Loading

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    1 similar comment
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 2, 2023 •
    edited
    Loading

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 2, 2023 •
    edited
    Loading

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    @jpeng-ms jpeng-ms marked this pull request as ready for review May 2, 2023 18:10
    @jpeng-ms jpeng-ms requested a review from a team as a code owner May 2, 2023 18:10
    @jpeng-ms jpeng-ms requested review from stewartadam and bexxx and removed request for a team May 2, 2023 18:10
    @jpeng-ms jpeng-ms merged commit 8c1f4f4 into jpeng/file-sharing-poc May 2, 2023
    @jpeng-ms jpeng-ms deleted the jpeng/file-sharing-complete branch May 2, 2023 18:10
    jhendrixMSFT pushed a commit that referenced this pull request May 30, 2023
    @jpeng-ms @JoshuaLai
    [Communication][Chat] Added new attachment type of "file" (#23662)
    ed5ff62 
    * Create communicationserviceschat.json

* [Update] New tag in readme

* added examples

* Update readme.md

* updated spec

* added file attachment example

* fixed unknown word issue

* init

* removing 2023-06-01

* Update readme.md

* Update communicationserviceschat.json

* Added teamsImage (#23793)

---------

Co-authored-by: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @stewartadam stewartadam Awaiting requested review from stewartadam stewartadam was automatically assigned from Azure/api-stewardship-board

    @bexxx bexxx Awaiting requested review from bexxx bexxx was automatically assigned from Azure/api-stewardship-board

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    1 participant
    @jpeng-ms