From cff505f2df32de5f1ef98c503db39dd6a4b9c103 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Tue, 12 Jan 2021 14:21:34 -0800 Subject: [PATCH 01/50] SettingFolder Structure. --- .../2021-01-12/communicationservicessms.json | 145 ++++++++++++++++++ .../stable/2021-01-12/examples/send.json | 23 +++ 2 files changed, 168 insertions(+) create mode 100644 specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/communicationservicessms.json create mode 100644 specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/examples/send.json diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/communicationservicessms.json new file mode 100644 index 000000000000..0d989bdbeee6 --- /dev/null +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/communicationservicessms.json @@ -0,0 +1,145 @@ +{ + "swagger": "2.0", + "info": { + "title": "Azure Communication SMS Service", + "description": "Azure Communication SMS Service", + "contact": { + "email": "acsdevexdisc@microsoft.com" + }, + "version": "2020-07-20-preview1" + }, + "securityDefinitions": { + "azure_auth": { + "type": "oauth2", + "authorizationUrl": "https://login.microsoftonline.com/common/oauth2/authorize", + "flow": "implicit", + "description": "Azure Active Directory OAuth2 Flow", + "scopes": { + "user_impersonation": "impersonate your user account" + } + } + }, + "paths": { + "/sms": { + "post": { + "tags": [ + "Sms" + ], + "summary": "Sends a SMS message from a phone number that belongs to the authenticated account.", + "operationId": "Sms_Send", + "x-ms-examples": { + "SuccessfulSend": { + "$ref": "./examples/send.json" + } + }, + "consumes": [ + "application/json" + ], + "produces": [ + "application/json" + ], + "parameters": [ + { + "in": "body", + "name": "SendMessageRequest", + "description": "Represents the body of the send message request.", + "required": true, + "schema": { + "$ref": "#/definitions/SendMessageRequest" + } + }, + { + "name": "api-version", + "in": "query", + "description": "Version of API to invoke.", + "required": true, + "type": "string" + } + ], + "responses": { + "200": { + "description": "SMS message is successfully scheduled for sending.", + "schema": { + "$ref": "#/definitions/SendSmsResponse" + } + } + } + } + } + }, + "definitions": { + "SendSmsOptions": { + "description": "Optional configuration for sending SMS messages", + "type": "object", + "properties": { + "enableDeliveryReport": { + "description": "Enable this flag to receive a delivery report for this message on the Azure Resource EventGrid", + "type": "boolean" + } + } + }, + "SendMessageRequest": { + "description": "Represents the properties of a send message request.", + "required": [ + "message", + "to", + "from" + ], + "type": "object", + "properties": { + "from": { + "description": "The sender's phone number in E.164 format that is owned by the authenticated account.", + "type": "string" + }, + "to": { + "description": "The recipients' phone number in E.164 format. In this version, only one recipient in the list is supported.", + "maxLength": 1, + "minLength": 1, + "type": "array", + "items": { + "type": "string" + } + }, + "message": { + "description": "The contents of the message that will be sent to the recipient. The allowable content is defined by RFC 5724.", + "maxLength": 2048, + "minLength": 0, + "type": "string" + }, + "sendSmsOptions": { + "$ref": "#/definitions/SendSmsOptions" + } + } + }, + "SendSmsResponse": { + "description": "Response for a successful send Sms request.", + "type": "object", + "properties": { + "messageId": { + "description": "The identifier of the outgoing SMS message", + "type": "string" + } + } + } + }, + "parameters": { + "Endpoint": { + "in": "path", + "name": "endpoint", + "description": "The endpoint of the Azure Communication resource.", + "required": true, + "type": "string", + "x-ms-skip-url-encoding": true, + "x-ms-parameter-location": "client" + } + }, + "x-ms-parameterized-host": { + "hostTemplate": "{endpoint}", + "useSchemePrefix": false, + "parameters": [ + { + "$ref": "#/parameters/Endpoint" + } + ] + } +} diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/examples/send.json new file mode 100644 index 000000000000..306feda3416f --- /dev/null +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/examples/send.json @@ -0,0 +1,23 @@ +{ + "parameters": { + "SendMessageRequest": { + "from": "+18001110000", + "to": [ + "+18002220000" + ], + "message": "Hello world!", + "sendSmsOptions": { + "enableDeliveryReport": true + } + }, + "api-version": "2020-07-20-preview1", + "endpoint": "https://contoso.communication.azure.com/" + }, + "responses": { + "200": { + "body": { + "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3" + } + } + } +} From 1445b9eef7b232f76321a0614366d7a87716209a Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Tue, 12 Jan 2021 18:00:14 -0800 Subject: [PATCH 02/50] Updating SMS communication Swagger json for 1:N , customer content feature. --- .../communicationservicessms.json | 70 ++++++++++++++-- .../stable/2021-01-12/examples/send.json | 81 ++++++++++++++++++- 2 files changed, 140 insertions(+), 11 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/preview/2020-07-20-preview1/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/preview/2020-07-20-preview1/communicationservicessms.json index 0d989bdbeee6..c8ca503b26f1 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/preview/2020-07-20-preview1/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/preview/2020-07-20-preview1/communicationservicessms.json @@ -6,7 +6,7 @@ "contact": { "email": "acsdevexdisc@microsoft.com" }, - "version": "2020-07-20-preview1" + "version": "2021-02-01-ga1" }, "securityDefinitions": { "azure_auth": { @@ -57,12 +57,45 @@ } ], "responses": { - "200": { - "description": "SMS message is successfully scheduled for sending.", + "202": { + "description": "Accepted", "schema": { - "$ref": "#/definitions/SendSmsResponse" + "type": "array", + "items": { + "$ref": "#/definitions/SendSmsResponse" + } + } + }, + "207": { + "description": "Multi Status", + "schema": { + "type": "array", + "items": { + "$ref": "#/definitions/SendSmsResponse" + } + } + }, + "400": { + "description": "Bad Request", + "schema": { + "type": "array", + "items": { + "$ref": "#/definitions/SendSmsResponse" + } + } + }, + "500": { + "description": "Internal Server Error", + "schema": { + "type": "array", + "items": { + "$ref": "#/definitions/SendSmsResponse" + } } } + }, + "x-ms-pageable": { + "nextLinkName": "nextLink" } } } @@ -75,6 +108,10 @@ "enableDeliveryReport": { "description": "Enable this flag to receive a delivery report for this message on the Azure Resource EventGrid", "type": "boolean" + }, + "tag": { + "description": "Enable extra customer content support.", + "type": "string" } } }, @@ -93,7 +130,7 @@ }, "to": { "description": "The recipients' phone number in E.164 format. In this version, only one recipient in the list is supported.", - "maxLength": 1, + "maxLength": 100, "minLength": 1, "type": "array", "items": { @@ -112,11 +149,30 @@ } }, "SendSmsResponse": { - "description": "Response for a successful send Sms request.", "type": "object", "properties": { + "details": { + "type": "array", + "items": { + "type": "object", + "$ref": "#/definitions/SendSmsResponseItem" + } + } + } + }, + "SendSmsResponseItem": { + "type": "object", + "properties": { + "to": { + "type": "string" + }, "messageId": { - "description": "The identifier of the outgoing SMS message", + "type": "string" + }, + "code": { + "type": "string" + }, + "message": { "type": "string" } } diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/examples/send.json index 306feda3416f..7725478a15a9 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/examples/send.json @@ -3,21 +3,94 @@ "SendMessageRequest": { "from": "+18001110000", "to": [ - "+18002220000" + "+11234567890", + "+11234567891" ], "message": "Hello world!", "sendSmsOptions": { "enableDeliveryReport": true } }, - "api-version": "2020-07-20-preview1", + "api-version": "2021-02-01-ga1", "endpoint": "https://contoso.communication.azure.com/" }, "responses": { - "200": { + "202": { + "headers": {}, "body": { - "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3" + "details": [ + { + "to": "+11234567890", + "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3", + "code": "HttpStatusCode.Accepted", + "message": "Accepted" + }, + { + "to": "+11234567891", + "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", + "code": "HttpStatusCode.Accepted", + "message": "Accepted" + } + ] + } + }, + "207": { + "headers": {}, + "body": { + "details": [ + { + "to": "+11234567890", + "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3", + "code": "HttpStatusCode.Accepted", + "message": "Accepted" + }, + { + "to": "+112345678901", + "messageId": "null", + "code": "HttpStatusCode.BadRequest", + "message": "BadRequest" + } + ] + } + }, + "400": { + "headers": {}, + "body": { + "details": [ + { + "to": "+11234567890", + "messageId": "null", + "code": "HttpStatusCode.BadRequest", + "message": "BadRequest" + }, + { + "to": "+112345678901", + "messageId": "null", + "code": "HttpStatusCode.InternalServerError", + "message": "InternalServerError" + } + ] + } + }, + "500": { + "headers": {}, + "body": { + "details": [ + { + "to": "+11234567890", + "messageId": "null", + "code": "HttpStatusCode.InternalServerError", + "message": "InternalServerError" + }, + { + "to": "+112345678901", + "messageId": "null", + "code": "HttpStatusCode.ServiceUnavailable", + "message": "ServiceUnavailable" + } + ] } } } } + From 0500536fe4726dc056fcd41676f684434dc42dc7 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 13 Jan 2021 13:00:10 -0800 Subject: [PATCH 03/50] Updating with review comments. --- .../communicationservicessms.json | 70 ++---------------- .../communicationservicessms.json | 71 +++++++++++++++++-- .../examples/send.json | 2 +- 3 files changed, 72 insertions(+), 71 deletions(-) rename specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/{2021-01-12 => 2021-03-07}/communicationservicessms.json (68%) rename specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/{2021-01-12 => 2021-03-07}/examples/send.json (98%) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/preview/2020-07-20-preview1/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/preview/2020-07-20-preview1/communicationservicessms.json index c8ca503b26f1..0d989bdbeee6 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/preview/2020-07-20-preview1/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/preview/2020-07-20-preview1/communicationservicessms.json @@ -6,7 +6,7 @@ "contact": { "email": "acsdevexdisc@microsoft.com" }, - "version": "2021-02-01-ga1" + "version": "2020-07-20-preview1" }, "securityDefinitions": { "azure_auth": { @@ -57,45 +57,12 @@ } ], "responses": { - "202": { - "description": "Accepted", + "200": { + "description": "SMS message is successfully scheduled for sending.", "schema": { - "type": "array", - "items": { - "$ref": "#/definitions/SendSmsResponse" - } - } - }, - "207": { - "description": "Multi Status", - "schema": { - "type": "array", - "items": { - "$ref": "#/definitions/SendSmsResponse" - } - } - }, - "400": { - "description": "Bad Request", - "schema": { - "type": "array", - "items": { - "$ref": "#/definitions/SendSmsResponse" - } - } - }, - "500": { - "description": "Internal Server Error", - "schema": { - "type": "array", - "items": { - "$ref": "#/definitions/SendSmsResponse" - } + "$ref": "#/definitions/SendSmsResponse" } } - }, - "x-ms-pageable": { - "nextLinkName": "nextLink" } } } @@ -108,10 +75,6 @@ "enableDeliveryReport": { "description": "Enable this flag to receive a delivery report for this message on the Azure Resource EventGrid", "type": "boolean" - }, - "tag": { - "description": "Enable extra customer content support.", - "type": "string" } } }, @@ -130,7 +93,7 @@ }, "to": { "description": "The recipients' phone number in E.164 format. In this version, only one recipient in the list is supported.", - "maxLength": 100, + "maxLength": 1, "minLength": 1, "type": "array", "items": { @@ -149,30 +112,11 @@ } }, "SendSmsResponse": { + "description": "Response for a successful send Sms request.", "type": "object", "properties": { - "details": { - "type": "array", - "items": { - "type": "object", - "$ref": "#/definitions/SendSmsResponseItem" - } - } - } - }, - "SendSmsResponseItem": { - "type": "object", - "properties": { - "to": { - "type": "string" - }, "messageId": { - "type": "string" - }, - "code": { - "type": "string" - }, - "message": { + "description": "The identifier of the outgoing SMS message", "type": "string" } } diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json similarity index 68% rename from specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/communicationservicessms.json rename to specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 0d989bdbeee6..bfee9970a308 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -6,7 +6,7 @@ "contact": { "email": "acsdevexdisc@microsoft.com" }, - "version": "2020-07-20-preview1" + "version": "2021-03-07" }, "securityDefinitions": { "azure_auth": { @@ -41,6 +41,7 @@ "parameters": [ { "in": "body", + "header": "xs-ms-Repeatable-Id", "name": "SendMessageRequest", "description": "Represents the body of the send message request.", "required": true, @@ -57,12 +58,45 @@ } ], "responses": { - "200": { - "description": "SMS message is successfully scheduled for sending.", + "202": { + "description": "Accepted", "schema": { - "$ref": "#/definitions/SendSmsResponse" + "type": "array", + "items": { + "$ref": "#/definitions/SendSmsResponse" + } + } + }, + "207": { + "description": "Multi Status", + "schema": { + "type": "array", + "items": { + "$ref": "#/definitions/SendSmsResponse" + } + } + }, + "400": { + "description": "Bad Request", + "schema": { + "type": "array", + "items": { + "$ref": "#/definitions/SendSmsResponse" + } + } + }, + "500": { + "description": "Internal Server Error", + "schema": { + "type": "array", + "items": { + "$ref": "#/definitions/SendSmsResponse" + } } } + }, + "x-ms-pageable": { + "nextLinkName": "nextLink" } } } @@ -75,6 +109,10 @@ "enableDeliveryReport": { "description": "Enable this flag to receive a delivery report for this message on the Azure Resource EventGrid", "type": "boolean" + }, + "tag": { + "description": "Use this field to provide metadata that will then be send back in the corresponding Delivery Report.", + "type": "string" } } }, @@ -93,7 +131,7 @@ }, "to": { "description": "The recipients' phone number in E.164 format. In this version, only one recipient in the list is supported.", - "maxLength": 1, + "maxLength": 100, "minLength": 1, "type": "array", "items": { @@ -112,11 +150,30 @@ } }, "SendSmsResponse": { - "description": "Response for a successful send Sms request.", "type": "object", "properties": { + "details": { + "type": "array", + "items": { + "type": "object", + "$ref": "#/definitions/SendSmsResponseItem" + } + } + } + }, + "SendSmsResponseItem": { + "type": "object", + "properties": { + "to": { + "type": "string" + }, "messageId": { - "description": "The identifier of the outgoing SMS message", + "type": "string" + }, + "code": { + "type": "string" + }, + "message": { "type": "string" } } diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json similarity index 98% rename from specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/examples/send.json rename to specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index 7725478a15a9..f8a5c772880d 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-01-12/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -11,7 +11,7 @@ "enableDeliveryReport": true } }, - "api-version": "2021-02-01-ga1", + "api-version": "2021-03-07", "endpoint": "https://contoso.communication.azure.com/" }, "responses": { From ce1a5e231ec86ac375fd4dd3357efc27ece58d30 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 13 Jan 2021 13:48:35 -0800 Subject: [PATCH 04/50] adding Idempotency header. --- .../stable/2021-03-07/communicationservicessms.json | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index bfee9970a308..1d283295289e 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -41,7 +41,6 @@ "parameters": [ { "in": "body", - "header": "xs-ms-Repeatable-Id", "name": "SendMessageRequest", "description": "Represents the body of the send message request.", "required": true, @@ -55,6 +54,13 @@ "description": "Version of API to invoke.", "required": true, "type": "string" + }, + { + "name": "x-ms-RepeatableId", + "in": "header", + "description": "Repeatable request id.This should be unique Guid.", + "required": false, + "type": "string" } ], "responses": { From 1ff127be834be327756e53794ff4f5f2d659a3fa Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 13 Jan 2021 14:42:05 -0800 Subject: [PATCH 05/50] Updating name for Idempodency field. --- .../stable/2021-03-07/communicationservicessms.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 1d283295289e..655b7d246393 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -56,9 +56,9 @@ "type": "string" }, { - "name": "x-ms-RepeatableId", + "name": "Repeatability-Request-ID", "in": "header", - "description": "Repeatable request id.This should be unique Guid.", + "description": "Represents unique GUID that enables repeatability.", "required": false, "type": "string" } From 60de17e7139110e2b349bb82168accd8d21dcb4e Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 13 Jan 2021 16:55:29 -0800 Subject: [PATCH 06/50] Merging N:1 Changes --- .../2021-03-07/communicationservicessms.json | 51 ++++++--------- .../stable/2021-03-07/examples/send.json | 62 ++++--------------- 2 files changed, 31 insertions(+), 82 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 655b7d246393..0ea5f324b39b 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -67,37 +67,13 @@ "202": { "description": "Accepted", "schema": { - "type": "array", - "items": { - "$ref": "#/definitions/SendSmsResponse" - } + "$ref": "#/definitions/SendSmsResponse" } }, "207": { "description": "Multi Status", "schema": { - "type": "array", - "items": { - "$ref": "#/definitions/SendSmsResponse" - } - } - }, - "400": { - "description": "Bad Request", - "schema": { - "type": "array", - "items": { - "$ref": "#/definitions/SendSmsResponse" - } - } - }, - "500": { - "description": "Internal Server Error", - "schema": { - "type": "array", - "items": { - "$ref": "#/definitions/SendSmsResponse" - } + "$ref": "#/definitions/SendSmsResponse" } } }, @@ -136,7 +112,7 @@ "type": "string" }, "to": { - "description": "The recipients' phone number in E.164 format. In this version, only one recipient in the list is supported.", + "description": "The recipients' phone number in E.164 format. In this version, a minimum of 1 and upto 100 recipients in the list are supported.", "maxLength": 100, "minLength": 1, "type": "array", @@ -156,30 +132,43 @@ } }, "SendSmsResponse": { + "description": "Response for a successful or multi status send Sms request.", "type": "object", "properties": { - "details": { + "value": { "type": "array", "items": { "type": "object", "$ref": "#/definitions/SendSmsResponseItem" } + }, + "nextLink": { + "type": "string" } } }, "SendSmsResponseItem": { + "description": "Response for a single recipient.", + "required": [ + "httpstatuscode", + "to" + ], "type": "object", "properties": { "to": { + "description": "The recipients' phone number in E.164 format", "type": "string" }, "messageId": { + "description": "The identifier of the outgoing SMS message. Only present if message processed", "type": "string" }, - "code": { - "type": "string" + "httpstatuscode": { + "description": "HTTP Status code", + "type": "int " }, - "message": { + "errormessage": { + "description": "Optional error message in case of 4xx or 5xx errors", "type": "string" } } diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index f8a5c772880d..e7631d64c6bc 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -18,77 +18,37 @@ "202": { "headers": {}, "body": { - "details": [ + "value": [ { "to": "+11234567890", "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3", - "code": "HttpStatusCode.Accepted", - "message": "Accepted" + "httpstatuscode": 202 }, { "to": "+11234567891", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", - "code": "HttpStatusCode.Accepted", - "message": "Accepted" + "httpstatuscode": 202 } - ] + ], + "nextLink": "null" } }, "207": { "headers": {}, "body": { - "details": [ + "value": [ { "to": "+11234567890", "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3", - "code": "HttpStatusCode.Accepted", - "message": "Accepted" + "httpstatuscode": 202 }, { "to": "+112345678901", - "messageId": "null", - "code": "HttpStatusCode.BadRequest", - "message": "BadRequest" + "httpstatuscode": 400, + "errormessage": "Invalid number format" } - ] - } - }, - "400": { - "headers": {}, - "body": { - "details": [ - { - "to": "+11234567890", - "messageId": "null", - "code": "HttpStatusCode.BadRequest", - "message": "BadRequest" - }, - { - "to": "+112345678901", - "messageId": "null", - "code": "HttpStatusCode.InternalServerError", - "message": "InternalServerError" - } - ] - } - }, - "500": { - "headers": {}, - "body": { - "details": [ - { - "to": "+11234567890", - "messageId": "null", - "code": "HttpStatusCode.InternalServerError", - "message": "InternalServerError" - }, - { - "to": "+112345678901", - "messageId": "null", - "code": "HttpStatusCode.ServiceUnavailable", - "message": "ServiceUnavailable" - } - ] + ], + "nextLink": "null" } } } From 73ffb472618a50080ed4bad05ece11c123bd1a58 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 13 Jan 2021 20:15:39 -0800 Subject: [PATCH 07/50] fixing integer issue --- .../stable/2021-03-07/communicationservicessms.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 0ea5f324b39b..d336f1b2eced 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -165,7 +165,7 @@ }, "httpstatuscode": { "description": "HTTP Status code", - "type": "int " + "type": "integer" }, "errormessage": { "description": "Optional error message in case of 4xx or 5xx errors", From 4466f82274619b411dcfabb77e849472dfd5cc3b Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 13 Jan 2021 20:48:56 -0800 Subject: [PATCH 08/50] Updating Read me --- specification/communication/data-plane/readme.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/specification/communication/data-plane/readme.md b/specification/communication/data-plane/readme.md index 7087d1970d8c..91aef86e5ba6 100644 --- a/specification/communication/data-plane/readme.md +++ b/specification/communication/data-plane/readme.md @@ -86,6 +86,15 @@ input-file: - Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json ``` +### Tag: package-2021-03-07 + +These settings apply only when `--tag=package-2021-03-07` is specified on the command line. + +```yaml $(tag) == 'package-2021-03-07' +input-file: + - Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +``` + --- # Code Generation From 76f84c23bd4994390d058639240e55d57f0e42c2 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 13 Jan 2021 21:03:33 -0800 Subject: [PATCH 09/50] fixing lint issue. --- .../stable/2021-03-07/communicationservicessms.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index d336f1b2eced..08f288f26bfb 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -64,7 +64,7 @@ } ], "responses": { - "202": { + "200": { "description": "Accepted", "schema": { "$ref": "#/definitions/SendSmsResponse" From 8636501fa825960698dc7912c7de74ff7eb2f9c3 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 13 Jan 2021 21:07:32 -0800 Subject: [PATCH 10/50] Reverting change --- .../stable/2021-03-07/communicationservicessms.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 08f288f26bfb..f08e9e02c4eb 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -64,7 +64,7 @@ } ], "responses": { - "200": { + "201": { "description": "Accepted", "schema": { "$ref": "#/definitions/SendSmsResponse" From 83f24db8cb689699d54c12cb775bdded4b460e35 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 13 Jan 2021 21:19:17 -0800 Subject: [PATCH 11/50] Fixing Model issue. --- .../stable/2021-03-07/communicationservicessms.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index f08e9e02c4eb..d336f1b2eced 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -64,7 +64,7 @@ } ], "responses": { - "201": { + "202": { "description": "Accepted", "schema": { "$ref": "#/definitions/SendSmsResponse" From be747168e3cb27eb6e70b7bb4eac3ebfe0fa7585 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Thu, 14 Jan 2021 12:03:19 -0800 Subject: [PATCH 12/50] Updating Case for repeatablity header. --- .../stable/2021-03-07/communicationservicessms.json | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index d336f1b2eced..3fef4c28d9f7 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -56,10 +56,9 @@ "type": "string" }, { - "name": "Repeatability-Request-ID", "in": "header", - "description": "Represents unique GUID that enables repeatability.", - "required": false, + "name": "repeatability-Request-ID", + "description": "If specified, the client directs that the request is repeatable; that is, that the client can make the request multiple times with the same Repeatability-Request-ID and get back an appropriate response without the server executing the request multiple times. The value of the Repeatability-Request-ID is an opaque string representing a client-generated, GUID, identifier for the request.", "type": "string" } ], From cdb3d5aabb089330bd5fed7ebe1f26dfc87d7b65 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Fri, 15 Jan 2021 12:42:34 -0800 Subject: [PATCH 13/50] Example update in sendjson. --- .../stable/2021-03-07/examples/send.json | 54 +++++++++++++------ 1 file changed, 37 insertions(+), 17 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index e7631d64c6bc..35749ae2b0bc 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -1,19 +1,35 @@ { - "parameters": { - "SendMessageRequest": { - "from": "+18001110000", - "to": [ - "+11234567890", - "+11234567891" - ], - "message": "Hello world!", - "sendSmsOptions": { - "enableDeliveryReport": true + "api-version": "2021-03-07", + "endpoint": "https://contoso.communication.azure.com/", + "parameters": [ + { + "SendMessageRequest": { + "from": "+18001110000", + "to": [ + "+11234567890", + "+11234567891" + ], + "message": "Hello world!", + "sendSmsOptions": { + "enableDeliveryReport": true + } } }, - "api-version": "2021-03-07", - "endpoint": "https://contoso.communication.azure.com/" - }, + { + "SendMessageRequest": { + "from": "+18001110000", + "to": [ + "+11234567890", + "+112345678901", + "+11234567892" + ], + "message": "Hello world!", + "sendSmsOptions": { + "enableDeliveryReport": true + } + } + } + ], "responses": { "202": { "headers": {}, @@ -29,8 +45,7 @@ "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", "httpstatuscode": 202 } - ], - "nextLink": "null" + ] } }, "207": { @@ -46,11 +61,16 @@ "to": "+112345678901", "httpstatuscode": 400, "errormessage": "Invalid number format" + }, + { + "to": "+11234567892", + "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", + "httpstatuscode": 503, + "errormessage": "ServiceUnavailable" } ], - "nextLink": "null" + "nextLink": "/someNextLink" } } } } - From 1d794c011ce27397099f69b5a1887952fbfc0429 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Fri, 15 Jan 2021 12:50:03 -0800 Subject: [PATCH 14/50] Review comments. --- .../stable/2021-03-07/communicationservicessms.json | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 3fef4c28d9f7..81cd50eff537 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -58,7 +58,7 @@ { "in": "header", "name": "repeatability-Request-ID", - "description": "If specified, the client directs that the request is repeatable; that is, that the client can make the request multiple times with the same Repeatability-Request-ID and get back an appropriate response without the server executing the request multiple times. The value of the Repeatability-Request-ID is an opaque string representing a client-generated, GUID, identifier for the request.", + "description": "If specified, the client directs that the request is repeatable; that is, the client can make the request multiple times with the same Repeatability-Request-ID and get back an appropriate response without the server executing the request multiple times. The value of the Repeatability-Request-ID is an opaque string representing a client-generated, GUID, identifier for the request.", "type": "string" } ], @@ -132,6 +132,9 @@ }, "SendSmsResponse": { "description": "Response for a successful or multi status send Sms request.", + "required": [ + "value" + ], "type": "object", "properties": { "value": { @@ -149,7 +152,7 @@ "SendSmsResponseItem": { "description": "Response for a single recipient.", "required": [ - "httpstatuscode", + "httpStatusCode", "to" ], "type": "object", @@ -162,11 +165,11 @@ "description": "The identifier of the outgoing SMS message. Only present if message processed", "type": "string" }, - "httpstatuscode": { + "httpStatusCode": { "description": "HTTP Status code", "type": "integer" }, - "errormessage": { + "errorMessage": { "description": "Optional error message in case of 4xx or 5xx errors", "type": "string" } From 8f21ae7cca06e976e867dcad135eebe2665bc892 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Fri, 15 Jan 2021 14:52:53 -0800 Subject: [PATCH 15/50] camelCase issue in Send.json. --- .../stable/2021-03-07/examples/send.json | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index 35749ae2b0bc..f0515116aa2b 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -38,12 +38,12 @@ { "to": "+11234567890", "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3", - "httpstatuscode": 202 + "httpStatusCode": 202 }, { "to": "+11234567891", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", - "httpstatuscode": 202 + "httpStatusCode": 202 } ] } @@ -55,18 +55,18 @@ { "to": "+11234567890", "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3", - "httpstatuscode": 202 + "httpStatusCode": 202 }, { "to": "+112345678901", - "httpstatuscode": 400, - "errormessage": "Invalid number format" + "httpStatusCode": 400, + "errorMessage": "Invalid number format" }, { "to": "+11234567892", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", - "httpstatuscode": 503, - "errormessage": "ServiceUnavailable" + "httpStatusCode": 503, + "errorMessage": "ServiceUnavailable" } ], "nextLink": "/someNextLink" From 248eba43b5091779e194731b5655b96dfb1af1b8 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Fri, 15 Jan 2021 15:15:09 -0800 Subject: [PATCH 16/50] Fixing example Model. --- .../stable/2021-03-07/examples/send.json | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index f0515116aa2b..bf72d6899cd9 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -1,6 +1,4 @@ { - "api-version": "2021-03-07", - "endpoint": "https://contoso.communication.azure.com/", "parameters": [ { "SendMessageRequest": { @@ -12,7 +10,9 @@ "message": "Hello world!", "sendSmsOptions": { "enableDeliveryReport": true - } + }, + "api-version": "2021-03-07", + "endpoint": "https://contoso.communication.azure.com/" } }, { @@ -26,7 +26,9 @@ "message": "Hello world!", "sendSmsOptions": { "enableDeliveryReport": true - } + }, + "api-version": "2021-03-07", + "endpoint": "https://contoso.communication.azure.com/" } } ], From a9cb67f460bdca69719f16d74d6b01774b59e6b9 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Fri, 15 Jan 2021 15:28:23 -0800 Subject: [PATCH 17/50] Model issue fix. --- .../stable/2021-03-07/examples/send.json | 46 ++++++------------- 1 file changed, 14 insertions(+), 32 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index bf72d6899cd9..0880a03f8889 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -1,37 +1,19 @@ { - "parameters": [ - { - "SendMessageRequest": { - "from": "+18001110000", - "to": [ - "+11234567890", - "+11234567891" - ], - "message": "Hello world!", - "sendSmsOptions": { - "enableDeliveryReport": true - }, - "api-version": "2021-03-07", - "endpoint": "https://contoso.communication.azure.com/" - } - }, - { - "SendMessageRequest": { - "from": "+18001110000", - "to": [ - "+11234567890", - "+112345678901", - "+11234567892" - ], - "message": "Hello world!", - "sendSmsOptions": { - "enableDeliveryReport": true - }, - "api-version": "2021-03-07", - "endpoint": "https://contoso.communication.azure.com/" - } + "parameters": { + "SendMessageRequest": { + "from": "+18001110000", + "to": [ + "+11234567890", + "+11234567891" + ], + "message": "Hello world!", + "sendSmsOptions": { + "enableDeliveryReport": true + }, + "api-version": "2021-03-07", + "endpoint": "https://contoso.communication.azure.com/" } - ], + }, "responses": { "202": { "headers": {}, From 0cee45df3ae675647a7635a46657475b2ba13db8 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Fri, 15 Jan 2021 15:38:33 -0800 Subject: [PATCH 18/50] apiversion param issue --- .../stable/2021-03-07/examples/send.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index 0880a03f8889..e706a9ef85bb 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -1,5 +1,7 @@ { "parameters": { + "api-version": "2021-03-07", + "endpoint": "https://contoso.communication.azure.com/", "SendMessageRequest": { "from": "+18001110000", "to": [ @@ -9,9 +11,7 @@ "message": "Hello world!", "sendSmsOptions": { "enableDeliveryReport": true - }, - "api-version": "2021-03-07", - "endpoint": "https://contoso.communication.azure.com/" + } } }, "responses": { From 3fde0f4caeb650a99509b23bccc809d402d0a805 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Fri, 15 Jan 2021 16:09:52 -0800 Subject: [PATCH 19/50] Model issue --- .../stable/2021-03-07/examples/send.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index e706a9ef85bb..d134f29f26a0 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -1,7 +1,7 @@ { + "endpoint": "https://contoso.communication.azure.com/", + "api-version": "2021-03-07", "parameters": { - "api-version": "2021-03-07", - "endpoint": "https://contoso.communication.azure.com/", "SendMessageRequest": { "from": "+18001110000", "to": [ From 6f77bf4ed19322a07e9a0f93ba05b8122fbd84c1 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Fri, 15 Jan 2021 16:20:21 -0800 Subject: [PATCH 20/50] Model validation. --- .../stable/2021-03-07/examples/send.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index d134f29f26a0..0ad0709108d1 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -1,6 +1,4 @@ { - "endpoint": "https://contoso.communication.azure.com/", - "api-version": "2021-03-07", "parameters": { "SendMessageRequest": { "from": "+18001110000", @@ -12,7 +10,9 @@ "sendSmsOptions": { "enableDeliveryReport": true } - } + }, + "api-version": "2021-03-07", + "endpoint": "https://contoso.communication.azure.com/" }, "responses": { "202": { From a540834cf036dedb3da02f560efbe4451a5f6d82 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 20 Jan 2021 12:52:32 -0800 Subject: [PATCH 21/50] Review comments. --- .../2021-03-07/communicationservicessms.json | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 81cd50eff537..181d2f6dfad4 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -57,8 +57,20 @@ }, { "in": "header", - "name": "repeatability-Request-ID", - "description": "If specified, the client directs that the request is repeatable; that is, the client can make the request multiple times with the same Repeatability-Request-ID and get back an appropriate response without the server executing the request multiple times. The value of the Repeatability-Request-ID is an opaque string representing a client-generated, GUID, identifier for the request.", + "name": "repeatability-request-id", + "description": "If specified, the client directs that the request is repeatable; that is, the client can make the request multiple times with the same Repeatability-Request-ID and get back an appropriate response without the server executing the request multiple times. The value of the Repeatability-Request-ID is an opaque string representing a client-generated, 36-character hexadecimal case-insensitive encoding of a UUID (GUID), identifier for the request.", + "type": "string" + }, + { + "in": "header", + "name": "repeatability-first-sent", + "description": "MUST be sent by clients to specify that a request is repeatable. Repeatability-First-Sent is used to specify the date and time at which the request was first created.", + "type": "string" + }, + { + "in": "header", + "name": "repeatability-result", + "description": "MUST be returned to clients for a request that is repeatable. This response header in the result of a repeatable request with one of the case-insensitive values accepted or rejected.", "type": "string" } ], From 9dcc8e5392e0e8c395013e4189870bcbdf206d1c Mon Sep 17 00:00:00 2001 From: Ankita Mathur Date: Thu, 21 Jan 2021 10:32:26 -0800 Subject: [PATCH 22/50] Addressing API review comments: consolidating to 202Accepted response. --- .../2021-03-07/communicationservicessms.json | 18 +++++-------- .../stable/2021-03-07/examples/send.json | 25 ++++++------------- 2 files changed, 13 insertions(+), 30 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 181d2f6dfad4..8374d28a9ce0 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -80,12 +80,6 @@ "schema": { "$ref": "#/definitions/SendSmsResponse" } - }, - "207": { - "description": "Multi Status", - "schema": { - "$ref": "#/definitions/SendSmsResponse" - } } }, "x-ms-pageable": { @@ -96,7 +90,7 @@ }, "definitions": { "SendSmsOptions": { - "description": "Optional configuration for sending SMS messages", + "description": "Optional configuration for sending SMS messages.", "type": "object", "properties": { "enableDeliveryReport": { @@ -104,7 +98,7 @@ "type": "boolean" }, "tag": { - "description": "Use this field to provide metadata that will then be send back in the corresponding Delivery Report.", + "description": "Use this field to provide metadata that will then be sent back in the corresponding Delivery Report.", "type": "string" } } @@ -123,7 +117,7 @@ "type": "string" }, "to": { - "description": "The recipients' phone number in E.164 format. In this version, a minimum of 1 and upto 100 recipients in the list are supported.", + "description": "The recipient's phone number in E.164 format. In this version, a minimum of 1 and upto 100 recipients in the list are supported.", "maxLength": 100, "minLength": 1, "type": "array", @@ -174,15 +168,15 @@ "type": "string" }, "messageId": { - "description": "The identifier of the outgoing SMS message. Only present if message processed", + "description": "The identifier of the outgoing SMS message. Only present if message processed.", "type": "string" }, "httpStatusCode": { - "description": "HTTP Status code", + "description": "HTTP Status code.", "type": "integer" }, "errorMessage": { - "description": "Optional error message in case of 4xx or 5xx errors", + "description": "Optional error message in case of 4xx or 5xx errors.", "type": "string" } } diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index 0ad0709108d1..b6981ed99e64 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -4,7 +4,9 @@ "from": "+18001110000", "to": [ "+11234567890", - "+11234567891" + "+11234567891", + "+112345678901", + "+11234567892" ], "message": "Hello world!", "sendSmsOptions": { @@ -22,29 +24,17 @@ { "to": "+11234567890", "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3", - "httpStatusCode": 202 + "httpStatusCode": 200 }, { "to": "+11234567891", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", - "httpStatusCode": 202 - } - ] - } - }, - "207": { - "headers": {}, - "body": { - "value": [ - { - "to": "+11234567890", - "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3", - "httpStatusCode": 202 + "httpStatusCode": 200 }, { "to": "+112345678901", "httpStatusCode": 400, - "errorMessage": "Invalid number format" + "errorMessage": "Invalid To phone number format." }, { "to": "+11234567892", @@ -52,8 +42,7 @@ "httpStatusCode": 503, "errorMessage": "ServiceUnavailable" } - ], - "nextLink": "/someNextLink" + ] } } } From 1e02d00dfa9252613921ac127b0d1b87f6b6c805 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Thu, 21 Jan 2021 12:43:16 -0800 Subject: [PATCH 23/50] review comments. --- .../stable/2021-03-07/communicationservicessms.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 8374d28a9ce0..aa551eb337e1 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -94,7 +94,7 @@ "type": "object", "properties": { "enableDeliveryReport": { - "description": "Enable this flag to receive a delivery report for this message on the Azure Resource EventGrid", + "description": "Enable this flag to receive a delivery report for this message on the Azure Resource EventGrid.", "type": "boolean" }, "tag": { From cc484442cdaeaec07f3f91786c8edad6da461c2a Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Thu, 21 Jan 2021 12:46:46 -0800 Subject: [PATCH 24/50] review comments --- .../stable/2021-03-07/communicationservicessms.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index aa551eb337e1..d69293184ada 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -64,7 +64,7 @@ { "in": "header", "name": "repeatability-first-sent", - "description": "MUST be sent by clients to specify that a request is repeatable. Repeatability-First-Sent is used to specify the date and time at which the request was first created.", + "description": "MUST be sent by clients to specify that a request is repeatable. Repeatability-First-Sent is used to specify the date and time at which the request was first created.eg- Tue, 26 Mar 2019 16:06:51 GMT", "type": "string" }, { From 525892c8097eb72b03845a1312c294043966de01 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Thu, 21 Jan 2021 19:01:06 -0800 Subject: [PATCH 25/50] placing response header at right place. --- .../stable/2021-03-07/communicationservicessms.json | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index d69293184ada..956f491aec45 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -66,17 +66,18 @@ "name": "repeatability-first-sent", "description": "MUST be sent by clients to specify that a request is repeatable. Repeatability-First-Sent is used to specify the date and time at which the request was first created.eg- Tue, 26 Mar 2019 16:06:51 GMT", "type": "string" - }, - { - "in": "header", - "name": "repeatability-result", - "description": "MUST be returned to clients for a request that is repeatable. This response header in the result of a repeatable request with one of the case-insensitive values accepted or rejected.", - "type": "string" } ], "responses": { "202": { "description": "Accepted", + "headers": { + "repeatability-result": + { + "type": "string", + "description": "Result of repeatibility request, if repeatability-request-id is provided.Values could be accepted or rejected." + } + }, "schema": { "$ref": "#/definitions/SendSmsResponse" } From e5863f5d0d1cf4b71903b6e27c050d3d91e4de9e Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Thu, 21 Jan 2021 19:07:23 -0800 Subject: [PATCH 26/50] review comments --- .../stable/2021-03-07/communicationservicessms.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 956f491aec45..5eb35a6c92db 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -165,7 +165,7 @@ "type": "object", "properties": { "to": { - "description": "The recipients' phone number in E.164 format", + "description": "The recipients's phone number in E.164 format.", "type": "string" }, "messageId": { From dc652c9308ddcb19a73dbbb37498e63081dfde6e Mon Sep 17 00:00:00 2001 From: Ankita Mathur Date: Tue, 2 Feb 2021 13:20:11 -0800 Subject: [PATCH 27/50] Modifying wire objects to format [Resource][Method] and adding a flag to response --- .../2021-03-07/communicationservicessms.json | 24 ++++++++++++------- .../stable/2021-03-07/examples/send.json | 14 +++++++---- 2 files changed, 24 insertions(+), 14 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 5eb35a6c92db..c5f16d6dfba9 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -79,7 +79,7 @@ } }, "schema": { - "$ref": "#/definitions/SendSmsResponse" + "$ref": "#/definitions/SmsSendResponse" } } }, @@ -90,13 +90,14 @@ } }, "definitions": { - "SendSmsOptions": { + "SmsSendOptions": { "description": "Optional configuration for sending SMS messages.", "type": "object", "properties": { "enableDeliveryReport": { "description": "Enable this flag to receive a delivery report for this message on the Azure Resource EventGrid.", - "type": "boolean" + "type": "boolean", + "default": false }, "tag": { "description": "Use this field to provide metadata that will then be sent back in the corresponding Delivery Report.", @@ -132,12 +133,12 @@ "minLength": 0, "type": "string" }, - "sendSmsOptions": { - "$ref": "#/definitions/SendSmsOptions" + "smsSendOptions": { + "$ref": "#/definitions/SmsSendOptions" } } }, - "SendSmsResponse": { + "SmsSendResponse": { "description": "Response for a successful or multi status send Sms request.", "required": [ "value" @@ -148,7 +149,7 @@ "type": "array", "items": { "type": "object", - "$ref": "#/definitions/SendSmsResponseItem" + "$ref": "#/definitions/SmsSendResponseItem" } }, "nextLink": { @@ -156,11 +157,12 @@ } } }, - "SendSmsResponseItem": { + "SmsSendResponseItem": { "description": "Response for a single recipient.", "required": [ "httpStatusCode", - "to" + "to", + "succeeded" ], "type": "object", "properties": { @@ -176,6 +178,10 @@ "description": "HTTP Status code.", "type": "integer" }, + "succeeded": { + "description": "Flag to check if message processing succeeded or not.", + "type": "boolean" + }, "errorMessage": { "description": "Optional error message in case of 4xx or 5xx errors.", "type": "string" diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index b6981ed99e64..296bbf501008 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -9,7 +9,7 @@ "+11234567892" ], "message": "Hello world!", - "sendSmsOptions": { + "smsSendOptions": { "enableDeliveryReport": true } }, @@ -24,23 +24,27 @@ { "to": "+11234567890", "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3", - "httpStatusCode": 200 + "httpStatusCode": 200, + "succeeded": true }, { "to": "+11234567891", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", - "httpStatusCode": 200 + "httpStatusCode": 200, + "succeeded": true }, { "to": "+112345678901", "httpStatusCode": 400, - "errorMessage": "Invalid To phone number format." + "errorMessage": "Invalid To phone number format.", + "succeeded": false }, { "to": "+11234567892", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", "httpStatusCode": 503, - "errorMessage": "ServiceUnavailable" + "errorMessage": "ServiceUnavailable", + "succeeded": false } ] } From 72834f8d018039362e74d321aa54ea67fa07d558 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 3 Feb 2021 12:51:26 -0800 Subject: [PATCH 28/50] Review comments --- .../2021-03-07/communicationservicessms.json | 53 +++++++++++-------- .../stable/2021-03-07/examples/send.json | 42 +++++++++++++-- 2 files changed, 67 insertions(+), 28 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index c5f16d6dfba9..d1ccb6486bfa 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -54,30 +54,11 @@ "description": "Version of API to invoke.", "required": true, "type": "string" - }, - { - "in": "header", - "name": "repeatability-request-id", - "description": "If specified, the client directs that the request is repeatable; that is, the client can make the request multiple times with the same Repeatability-Request-ID and get back an appropriate response without the server executing the request multiple times. The value of the Repeatability-Request-ID is an opaque string representing a client-generated, 36-character hexadecimal case-insensitive encoding of a UUID (GUID), identifier for the request.", - "type": "string" - }, - { - "in": "header", - "name": "repeatability-first-sent", - "description": "MUST be sent by clients to specify that a request is repeatable. Repeatability-First-Sent is used to specify the date and time at which the request was first created.eg- Tue, 26 Mar 2019 16:06:51 GMT", - "type": "string" } ], "responses": { "202": { "description": "Accepted", - "headers": { - "repeatability-result": - { - "type": "string", - "description": "Result of repeatibility request, if repeatability-request-id is provided.Values could be accepted or rejected." - } - }, "schema": { "$ref": "#/definitions/SmsSendResponse" } @@ -90,6 +71,27 @@ } }, "definitions": { + "SmsRecipient": { + "description": "Recipient Details for sending SMS messages.", + "required": [ + "to" + ], + "type": "object", + "properties": { + "to": { + "description": "The recipient's phone number in E.164 format.", + "type": "string" + }, + "repeatability-request-id": { + "description": "If specified, the client directs that the request is repeatable; that is, the client can make the request multiple times with the same Repeatability-Request-ID and get back an appropriate response without the server executing the request multiple times. The value of the Repeatability-Request-ID is an opaque string representing a client-generated, 36-character hexadecimal case-insensitive encoding of a UUID (GUID), identifier for the request.", + "type": "string" + }, + "repeatability-first-sent": { + "description": "MUST be sent by clients to specify that a request is repeatable. Repeatability-First-Sent is used to specify the date and time at which the request was first created.eg- Tue, 26 Mar 2019 16:06:51 GMT", + "type": "string" + } + } + }, "SmsSendOptions": { "description": "Optional configuration for sending SMS messages.", "type": "object", @@ -109,7 +111,7 @@ "description": "Represents the properties of a send message request.", "required": [ "message", - "to", + "smsRecipient", "from" ], "type": "object", @@ -118,13 +120,14 @@ "description": "The sender's phone number in E.164 format that is owned by the authenticated account.", "type": "string" }, - "to": { + "smsRecipient": { "description": "The recipient's phone number in E.164 format. In this version, a minimum of 1 and upto 100 recipients in the list are supported.", "maxLength": 100, "minLength": 1, "type": "array", "items": { - "type": "string" + "type": "object", + "$ref": "#/definitions/SmsRecipient" } }, "message": { @@ -178,12 +181,16 @@ "description": "HTTP Status code.", "type": "integer" }, + "repeatability-result": { + "description": "The result of a repeatable request with one of the case-insensitive values accepted or rejected.", + "type": "string" + }, "succeeded": { "description": "Flag to check if message processing succeeded or not.", "type": "boolean" }, "errorMessage": { - "description": "Optional error message in case of 4xx or 5xx errors.", + "description": "Optional error message in case of 4xx/5xx/repeatibility errors.", "type": "string" } } diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index 296bbf501008..50c756279967 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -2,11 +2,28 @@ "parameters": { "SendMessageRequest": { "from": "+18001110000", - "to": [ - "+11234567890", - "+11234567891", - "+112345678901", - "+11234567892" + "recipient": [ + { + "to": "+11234567890" + }, + { + "to": "+11234567891" + }, + { + "to": "+112345678901" + }, + { + "to": "+11234567892" + }, + { + "to": "+11234567893", + "repeatability-request-id": "fda6d242-46aa-4247-8bf6-619a1206f9c3", + "repeatability-first-sent": "Mon, 01 Apr 2019 06:22:03 GMT" + }, + { + "to": "+11234567894", + "repeatability-request-id": "fda6d242-46aa-4247-8bf6-619a1206f9c3" + } ], "message": "Hello world!", "smsSendOptions": { @@ -45,6 +62,21 @@ "httpStatusCode": 503, "errorMessage": "ServiceUnavailable", "succeeded": false + }, + { + "to": "+11234567893", + "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822_noam", + "httpStatusCode": 200, + "repeatability-result": "accepted", + "succeeded": true + }, + { + "to": "+11234567894", + "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", + "httpStatusCode": 400, + "repeatability-result": "rejected", + "errorMessage": "Request sent with Invalid DateTime value for repeatability-first-sent.\r\n Expected is DateTime ,RFC1123 pattern.", + "succeeded": false } ] } From c52f83421147037a08d21d070bd631f4f3df2871 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 3 Feb 2021 12:55:47 -0800 Subject: [PATCH 29/50] Fixing swagger validations. --- .../stable/2021-03-07/communicationservicessms.json | 2 -- 1 file changed, 2 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index d1ccb6486bfa..6f2559f9427a 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -126,7 +126,6 @@ "minLength": 1, "type": "array", "items": { - "type": "object", "$ref": "#/definitions/SmsRecipient" } }, @@ -151,7 +150,6 @@ "value": { "type": "array", "items": { - "type": "object", "$ref": "#/definitions/SmsSendResponseItem" } }, From b72ca6d0e6b69b247d855bb3804ce75a5bbf95fd Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 3 Feb 2021 14:32:40 -0800 Subject: [PATCH 30/50] review comments. --- .../stable/2021-03-07/communicationservicessms.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 6f2559f9427a..44be1e435a58 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -3,9 +3,6 @@ "info": { "title": "Azure Communication SMS Service", "description": "Azure Communication SMS Service", - "contact": { - "email": "acsdevexdisc@microsoft.com" - }, "version": "2021-03-07" }, "securityDefinitions": { From ba8bc6d2fd674269ac0dcb1c9f0b4faf80ce87be Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 3 Feb 2021 14:35:36 -0800 Subject: [PATCH 31/50] review comments. --- .../stable/2021-03-07/communicationservicessms.json | 2 +- .../stable/2021-03-07/examples/send.json | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 44be1e435a58..47d65f64e30c 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -180,7 +180,7 @@ "description": "The result of a repeatable request with one of the case-insensitive values accepted or rejected.", "type": "string" }, - "succeeded": { + "successful": { "description": "Flag to check if message processing succeeded or not.", "type": "boolean" }, diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index 50c756279967..14c366f0c26e 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -42,33 +42,33 @@ "to": "+11234567890", "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3", "httpStatusCode": 200, - "succeeded": true + "successful": true }, { "to": "+11234567891", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", "httpStatusCode": 200, - "succeeded": true + "successful": true }, { "to": "+112345678901", "httpStatusCode": 400, "errorMessage": "Invalid To phone number format.", - "succeeded": false + "successful": false }, { "to": "+11234567892", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", "httpStatusCode": 503, "errorMessage": "ServiceUnavailable", - "succeeded": false + "successful": false }, { "to": "+11234567893", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822_noam", "httpStatusCode": 200, "repeatability-result": "accepted", - "succeeded": true + "successful": true }, { "to": "+11234567894", @@ -76,7 +76,7 @@ "httpStatusCode": 400, "repeatability-result": "rejected", "errorMessage": "Request sent with Invalid DateTime value for repeatability-first-sent.\r\n Expected is DateTime ,RFC1123 pattern.", - "succeeded": false + "successful": false } ] } From d4f2cf6330bdb61fdb2c00ad7ec2496021ee7ae5 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 3 Feb 2021 14:47:43 -0800 Subject: [PATCH 32/50] review comments. --- .../stable/2021-03-07/communicationservicessms.json | 7 ++++--- .../stable/2021-03-07/examples/send.json | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 47d65f64e30c..dd1de4118a2f 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -69,7 +69,7 @@ }, "definitions": { "SmsRecipient": { - "description": "Recipient Details for sending SMS messages.", + "description": "Recipient details for sending SMS messages.", "required": [ "to" ], @@ -178,10 +178,11 @@ }, "repeatability-result": { "description": "The result of a repeatable request with one of the case-insensitive values accepted or rejected.", - "type": "string" + "type": "string", + "enum": [ "accepted", "rejected" ] }, "successful": { - "description": "Flag to check if message processing succeeded or not.", + "description": "Indicates if the message is processed successfully or not.", "type": "boolean" }, "errorMessage": { diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index 14c366f0c26e..919ad14022a3 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -75,7 +75,7 @@ "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", "httpStatusCode": 400, "repeatability-result": "rejected", - "errorMessage": "Request sent with Invalid DateTime value for repeatability-first-sent.\r\n Expected is DateTime ,RFC1123 pattern.", + "errorMessage": "Request sent with Invalid DateTime value for repeatability-first-sent. Expected is DateTime ,RFC1123 pattern.", "successful": false } ] From 964f4bfa1e9ea4fbf8d6770366a6b9219b14ddac Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 3 Feb 2021 15:13:26 -0800 Subject: [PATCH 33/50] review comments. --- .../stable/2021-03-07/communicationservicessms.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index dd1de4118a2f..d98f26d39277 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -91,6 +91,9 @@ }, "SmsSendOptions": { "description": "Optional configuration for sending SMS messages.", + "required": [ + "enableDeliveryReport" + ], "type": "object", "properties": { "enableDeliveryReport": { From 8c4e09451fec427c70e27b0a9aa369d1d28785f4 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 3 Feb 2021 15:18:54 -0800 Subject: [PATCH 34/50] Swagger validation. --- .../stable/2021-03-07/communicationservicessms.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index d98f26d39277..f98859a198bb 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -163,7 +163,7 @@ "required": [ "httpStatusCode", "to", - "succeeded" + "successful" ], "type": "object", "properties": { From 8d026b5cbe5d6a0f3e75a3252a91f7587396b424 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 3 Feb 2021 15:26:42 -0800 Subject: [PATCH 35/50] review comments. --- .../stable/2021-03-07/examples/send.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index 919ad14022a3..a4273124fc61 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -2,7 +2,7 @@ "parameters": { "SendMessageRequest": { "from": "+18001110000", - "recipient": [ + "smsRecipient": [ { "to": "+11234567890" }, From 4f29e2f8dfb644ca0aefabdc5b27afc2e30c809d Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Thu, 4 Feb 2021 10:50:17 -0800 Subject: [PATCH 36/50] review comments --- .../stable/2021-03-07/communicationservicessms.json | 6 +++--- .../stable/2021-03-07/examples/send.json | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index f98859a198bb..73e6e54e44ea 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -79,11 +79,11 @@ "description": "The recipient's phone number in E.164 format.", "type": "string" }, - "repeatability-request-id": { + "repeatabilityRequestId": { "description": "If specified, the client directs that the request is repeatable; that is, the client can make the request multiple times with the same Repeatability-Request-ID and get back an appropriate response without the server executing the request multiple times. The value of the Repeatability-Request-ID is an opaque string representing a client-generated, 36-character hexadecimal case-insensitive encoding of a UUID (GUID), identifier for the request.", "type": "string" }, - "repeatability-first-sent": { + "repeatabilityFirstSent": { "description": "MUST be sent by clients to specify that a request is repeatable. Repeatability-First-Sent is used to specify the date and time at which the request was first created.eg- Tue, 26 Mar 2019 16:06:51 GMT", "type": "string" } @@ -179,7 +179,7 @@ "description": "HTTP Status code.", "type": "integer" }, - "repeatability-result": { + "repeatabilityResult": { "description": "The result of a repeatable request with one of the case-insensitive values accepted or rejected.", "type": "string", "enum": [ "accepted", "rejected" ] diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index a4273124fc61..84d0ca08c02b 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -17,12 +17,12 @@ }, { "to": "+11234567893", - "repeatability-request-id": "fda6d242-46aa-4247-8bf6-619a1206f9c3", - "repeatability-first-sent": "Mon, 01 Apr 2019 06:22:03 GMT" + "repeatabilityRequestId": "fda6d242-46aa-4247-8bf6-619a1206f9c3", + "repeatabilityFirstSent": "Mon, 01 Apr 2019 06:22:03 GMT" }, { "to": "+11234567894", - "repeatability-request-id": "fda6d242-46aa-4247-8bf6-619a1206f9c3" + "repeatabilityRequestId": "fda6d242-46aa-4247-8bf6-619a1206f9c3" } ], "message": "Hello world!", @@ -67,14 +67,14 @@ "to": "+11234567893", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822_noam", "httpStatusCode": 200, - "repeatability-result": "accepted", + "repeatabilityResult": "accepted", "successful": true }, { "to": "+11234567894", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", "httpStatusCode": 400, - "repeatability-result": "rejected", + "repeatabilityResult": "rejected", "errorMessage": "Request sent with Invalid DateTime value for repeatability-first-sent. Expected is DateTime ,RFC1123 pattern.", "successful": false } From 7719fa10ecb2909f388aa0b34fe44ed29b3af1b9 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Thu, 4 Feb 2021 11:38:30 -0800 Subject: [PATCH 37/50] Fix Avocado --- specification/communication/data-plane/readme.md | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/specification/communication/data-plane/readme.md b/specification/communication/data-plane/readme.md index 8c2640bc4d84..e7c9c4c4dfd7 100644 --- a/specification/communication/data-plane/readme.md +++ b/specification/communication/data-plane/readme.md @@ -84,6 +84,9 @@ These settings apply only when `--tag=package-2021-03-07` is specified on the co ```yaml $(tag) == 'package-2021-03-07' input-file: - Microsoft.CommunicationServicesIdentity/stable/2021-03-07/CommunicationIdentity.json + - Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +title: + Azure Communication Services ``` ### Tag: package-2021-02-22-preview1 @@ -104,15 +107,6 @@ input-file: - Microsoft.CommunicationServicesCommon/preview/2020-11-19-preview1/common.json ``` -### Tag: package-2021-03-07 - -These settings apply only when `--tag=package-2021-03-07` is specified on the command line. - -```yaml $(tag) == 'package-2021-03-07' -input-file: - - Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json -``` - --- # Code Generation From 57e2f268e545992bb43e2a1a9c4af240aa33ba24 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Mon, 8 Feb 2021 11:15:24 -0800 Subject: [PATCH 38/50] Fixing endpoint stuff --- .../2021-03-07/communicationservicessms.json | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 73e6e54e44ea..2a0c4d6fc8aa 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -196,22 +196,19 @@ } }, "parameters": { - "Endpoint": { - "in": "path", - "name": "endpoint", - "description": "The endpoint of the Azure Communication resource.", - "required": true, - "type": "string", - "x-ms-skip-url-encoding": true, - "x-ms-parameter-location": "client" - } }, "x-ms-parameterized-host": { "hostTemplate": "{endpoint}", "useSchemePrefix": false, "parameters": [ { - "$ref": "#/parameters/Endpoint" + "in": "path", + "name": "endpoint", + "description": "The endpoint of the Azure Communication resource.", + "required": true, + "type": "string", + "x-ms-skip-url-encoding": true, + "x-ms-parameter-location": "client" } ] } From 7c9e05aaa6e68a91803c0c51fb7f0f8a1b9604cf Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Mon, 8 Feb 2021 12:13:44 -0800 Subject: [PATCH 39/50] review comments --- .../stable/2021-03-07/communicationservicessms.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 2a0c4d6fc8aa..84467ab7324d 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -202,11 +202,11 @@ "useSchemePrefix": false, "parameters": [ { - "in": "path", "name": "endpoint", - "description": "The endpoint of the Azure Communication resource.", + "description": "The communication resource, for example https://my-resource.communication.azure.com", "required": true, "type": "string", + "in": "path", "x-ms-skip-url-encoding": true, "x-ms-parameter-location": "client" } From d943496150967c94d4ab98956fbabc032355d3d3 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Tue, 9 Feb 2021 10:52:10 -0800 Subject: [PATCH 40/50] review comments --- .../stable/2021-03-07/communicationservicessms.json | 6 ------ 1 file changed, 6 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 84467ab7324d..e0cea6caf5ba 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -60,9 +60,6 @@ "$ref": "#/definitions/SmsSendResponse" } } - }, - "x-ms-pageable": { - "nextLinkName": "nextLink" } } } @@ -152,9 +149,6 @@ "items": { "$ref": "#/definitions/SmsSendResponseItem" } - }, - "nextLink": { - "type": "string" } } }, From cf30608ac24965479814e52ffd0ad563cfc71d58 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 10 Feb 2021 12:05:04 -0800 Subject: [PATCH 41/50] fix spell --- .../stable/2021-03-07/communicationservicessms.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index e0cea6caf5ba..6544afe0b371 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -162,7 +162,7 @@ "type": "object", "properties": { "to": { - "description": "The recipients's phone number in E.164 format.", + "description": "The recipient's phone number in E.164 format.", "type": "string" }, "messageId": { @@ -183,7 +183,7 @@ "type": "boolean" }, "errorMessage": { - "description": "Optional error message in case of 4xx/5xx/repeatibility errors.", + "description": "Optional error message in case of 4xx/5xx/repeatable errors.", "type": "string" } } From aae4fb05017bde40d9a93510dbc33548ff806c36 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 10 Feb 2021 12:28:03 -0800 Subject: [PATCH 42/50] fixes --- .../stable/2021-03-07/communicationservicessms.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 6544afe0b371..bde177fccef0 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -166,7 +166,7 @@ "type": "string" }, "messageId": { - "description": "The identifier of the outgoing SMS message. Only present if message processed.", + "description": "The identifier of the outgoing Sms message. Only present if message processed.", "type": "string" }, "httpStatusCode": { From 4d917ceced7bd21ce88bbd39a73bc830e80aae27 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 10 Feb 2021 13:27:35 -0800 Subject: [PATCH 43/50] prettierfix --- .../stable/2021-03-07/communicationservicessms.json | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index bde177fccef0..7dc4c629129e 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -176,7 +176,10 @@ "repeatabilityResult": { "description": "The result of a repeatable request with one of the case-insensitive values accepted or rejected.", "type": "string", - "enum": [ "accepted", "rejected" ] + "enum": [ + "accepted", + "rejected" + ] }, "successful": { "description": "Indicates if the message is processed successfully or not.", @@ -189,8 +192,7 @@ } } }, - "parameters": { - }, + "parameters": {}, "x-ms-parameterized-host": { "hostTemplate": "{endpoint}", "useSchemePrefix": false, From 341eaf6c2a916bf5a53e85ba7abfb566574005c9 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 10 Feb 2021 13:33:51 -0800 Subject: [PATCH 44/50] fix --- package-lock.json | 2 +- .../2021-03-07/communicationservicessms.json | 2 +- tsconfig.json | 26 +++++++++---------- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/package-lock.json b/package-lock.json index 4097b8d804f1..8c13fe95be52 100644 --- a/package-lock.json +++ b/package-lock.json @@ -5017,7 +5017,7 @@ "prettier": { "version": "1.19.1", "resolved": "https://registry.npmjs.org/prettier/-/prettier-1.19.1.tgz", - "integrity": "sha1-99f1/4qc2HKnvkyhQglZVqYHl8s=", + "integrity": "sha512-s7PoyDv/II1ObgQunCbB9PdLmUcBZcnWOcxDh7O0N/UwDEsHyqkW+Qh28jW+mVuCdx7gLB0BotYI1Y6uI9iyew==", "dev": true }, "process-nextick-args": { diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 7dc4c629129e..e752574be0c7 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -22,7 +22,7 @@ "tags": [ "Sms" ], - "summary": "Sends a SMS message from a phone number that belongs to the authenticated account.", + "summary": "Sends a Sms message from a phone number that belongs to the authenticated account.", "operationId": "Sms_Send", "x-ms-examples": { "SuccessfulSend": { diff --git a/tsconfig.json b/tsconfig.json index 0556c9a9cc08..52f27a2a3cb2 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,27 +1,27 @@ { "compilerOptions": { /* Basic Options */ - "target": "es2019", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */ - "module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ + "target": "es2019" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */, + "module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */, // "lib": [], /* Specify library files to be included in the compilation. */ // "allowJs": true, /* Allow javascript files to be compiled. */ // "checkJs": true, /* Report errors in .js files. */ // "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */ - "declaration": true, /* Generates corresponding '.d.ts' file. */ - "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */ - "sourceMap": true, /* Generates corresponding '.map' file. */ + "declaration": true /* Generates corresponding '.d.ts' file. */, + "declarationMap": true /* Generates a sourcemap for each corresponding '.d.ts' file. */, + "sourceMap": true /* Generates corresponding '.map' file. */, // "outFile": "./", /* Concatenate and emit output to single file. */ // "outDir": "./dist", /* Redirect output structure to the directory. */ // "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */ // "composite": true, /* Enable project compilation */ // "removeComments": true, /* Do not emit comments to output. */ // "noEmit": true, /* Do not emit outputs. */ - "importHelpers": true, /* Import emit helpers from 'tslib'. */ + "importHelpers": true /* Import emit helpers from 'tslib'. */, // "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */ // "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */ /* Strict Type-Checking Options */ - "strict": true, /* Enable all strict type-checking options. */ + "strict": true /* Enable all strict type-checking options. */, // "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */ // "strictNullChecks": true, /* Enable strict null checks. */ // "strictFunctionTypes": true, /* Enable strict checking of function types. */ @@ -31,10 +31,10 @@ // "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */ /* Additional Checks */ - "noUnusedLocals": true, /* Report errors on unused locals. */ - "noUnusedParameters": true, /* Report errors on unused parameters. */ - "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */ - "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ + "noUnusedLocals": true /* Report errors on unused locals. */, + "noUnusedParameters": true /* Report errors on unused parameters. */, + "noImplicitReturns": true /* Report error when not all code paths in function return a value. */, + "noFallthroughCasesInSwitch": true /* Report errors for fallthrough cases in switch statement. */, /* Module Resolution Options */ // "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */ @@ -44,7 +44,7 @@ // "typeRoots": [], /* List of folders to include type definitions from. */ // "types": [], /* Type declaration files to be included in compilation. */ // "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */ - "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */ + "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */ // "preserveSymlinks": true, /* Do not resolve the real path of symlinks. */ /* Source Map Options */ @@ -57,4 +57,4 @@ // "experimentalDecorators": true, /* Enables experimental support for ES7 decorators. */ // "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */ } -} \ No newline at end of file +} From a061e429084b234929ace92f890a43665ccc2862 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 10 Feb 2021 13:34:33 -0800 Subject: [PATCH 45/50] Revert "fix" This reverts commit 341eaf6c2a916bf5a53e85ba7abfb566574005c9. --- package-lock.json | 2 +- .../2021-03-07/communicationservicessms.json | 2 +- tsconfig.json | 26 +++++++++---------- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/package-lock.json b/package-lock.json index 8c13fe95be52..4097b8d804f1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -5017,7 +5017,7 @@ "prettier": { "version": "1.19.1", "resolved": "https://registry.npmjs.org/prettier/-/prettier-1.19.1.tgz", - "integrity": "sha512-s7PoyDv/II1ObgQunCbB9PdLmUcBZcnWOcxDh7O0N/UwDEsHyqkW+Qh28jW+mVuCdx7gLB0BotYI1Y6uI9iyew==", + "integrity": "sha1-99f1/4qc2HKnvkyhQglZVqYHl8s=", "dev": true }, "process-nextick-args": { diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index e752574be0c7..7dc4c629129e 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -22,7 +22,7 @@ "tags": [ "Sms" ], - "summary": "Sends a Sms message from a phone number that belongs to the authenticated account.", + "summary": "Sends a SMS message from a phone number that belongs to the authenticated account.", "operationId": "Sms_Send", "x-ms-examples": { "SuccessfulSend": { diff --git a/tsconfig.json b/tsconfig.json index 52f27a2a3cb2..0556c9a9cc08 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,27 +1,27 @@ { "compilerOptions": { /* Basic Options */ - "target": "es2019" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */, - "module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */, + "target": "es2019", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */ + "module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ // "lib": [], /* Specify library files to be included in the compilation. */ // "allowJs": true, /* Allow javascript files to be compiled. */ // "checkJs": true, /* Report errors in .js files. */ // "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */ - "declaration": true /* Generates corresponding '.d.ts' file. */, - "declarationMap": true /* Generates a sourcemap for each corresponding '.d.ts' file. */, - "sourceMap": true /* Generates corresponding '.map' file. */, + "declaration": true, /* Generates corresponding '.d.ts' file. */ + "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */ + "sourceMap": true, /* Generates corresponding '.map' file. */ // "outFile": "./", /* Concatenate and emit output to single file. */ // "outDir": "./dist", /* Redirect output structure to the directory. */ // "rootDir": "./", /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */ // "composite": true, /* Enable project compilation */ // "removeComments": true, /* Do not emit comments to output. */ // "noEmit": true, /* Do not emit outputs. */ - "importHelpers": true /* Import emit helpers from 'tslib'. */, + "importHelpers": true, /* Import emit helpers from 'tslib'. */ // "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */ // "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */ /* Strict Type-Checking Options */ - "strict": true /* Enable all strict type-checking options. */, + "strict": true, /* Enable all strict type-checking options. */ // "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */ // "strictNullChecks": true, /* Enable strict null checks. */ // "strictFunctionTypes": true, /* Enable strict checking of function types. */ @@ -31,10 +31,10 @@ // "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */ /* Additional Checks */ - "noUnusedLocals": true /* Report errors on unused locals. */, - "noUnusedParameters": true /* Report errors on unused parameters. */, - "noImplicitReturns": true /* Report error when not all code paths in function return a value. */, - "noFallthroughCasesInSwitch": true /* Report errors for fallthrough cases in switch statement. */, + "noUnusedLocals": true, /* Report errors on unused locals. */ + "noUnusedParameters": true, /* Report errors on unused parameters. */ + "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */ + "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ /* Module Resolution Options */ // "moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */ @@ -44,7 +44,7 @@ // "typeRoots": [], /* List of folders to include type definitions from. */ // "types": [], /* Type declaration files to be included in compilation. */ // "allowSyntheticDefaultImports": true, /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */ - "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */ + "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */ // "preserveSymlinks": true, /* Do not resolve the real path of symlinks. */ /* Source Map Options */ @@ -57,4 +57,4 @@ // "experimentalDecorators": true, /* Enables experimental support for ES7 decorators. */ // "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */ } -} +} \ No newline at end of file From 83d782b99cb85a9b2f5ef22774584541dd0ff997 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Wed, 10 Feb 2021 14:36:16 -0800 Subject: [PATCH 46/50] review comments --- .../stable/2021-03-07/communicationservicessms.json | 4 ++-- .../stable/2021-03-07/examples/send.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index 7dc4c629129e..cc67cba7334d 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -108,7 +108,7 @@ "description": "Represents the properties of a send message request.", "required": [ "message", - "smsRecipient", + "smsRecipients", "from" ], "type": "object", @@ -117,7 +117,7 @@ "description": "The sender's phone number in E.164 format that is owned by the authenticated account.", "type": "string" }, - "smsRecipient": { + "smsRecipients": { "description": "The recipient's phone number in E.164 format. In this version, a minimum of 1 and upto 100 recipients in the list are supported.", "maxLength": 100, "minLength": 1, diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index 84d0ca08c02b..c3d699173b7d 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -2,7 +2,7 @@ "parameters": { "SendMessageRequest": { "from": "+18001110000", - "smsRecipient": [ + "smsRecipients": [ { "to": "+11234567890" }, From be87c1bfa8903922247079cbb84dc0bf66e22a80 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Fri, 19 Feb 2021 12:50:33 -0800 Subject: [PATCH 47/50] review comments --- .../stable/2021-03-07/examples/send.json | 6 +++--- specification/communication/data-plane/readme.md | 10 ++++++++++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index c3d699173b7d..35e260e6bddd 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -41,13 +41,13 @@ { "to": "+11234567890", "messageId": "Outgoing_20200610203725bfd4ba70-70bf-4f77-925d-c0bdb5161bb3", - "httpStatusCode": 200, + "httpStatusCode": 202, "successful": true }, { "to": "+11234567891", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822", - "httpStatusCode": 200, + "httpStatusCode": 202, "successful": true }, { @@ -66,7 +66,7 @@ { "to": "+11234567893", "messageId": "Outgoing_2020061020025100d1-d07e-4b19-b25d-13525d552822_noam", - "httpStatusCode": 200, + "httpStatusCode": 202, "repeatabilityResult": "accepted", "successful": true }, diff --git a/specification/communication/data-plane/readme.md b/specification/communication/data-plane/readme.md index e7c9c4c4dfd7..0dfa8595434d 100644 --- a/specification/communication/data-plane/readme.md +++ b/specification/communication/data-plane/readme.md @@ -84,6 +84,16 @@ These settings apply only when `--tag=package-2021-03-07` is specified on the co ```yaml $(tag) == 'package-2021-03-07' input-file: - Microsoft.CommunicationServicesIdentity/stable/2021-03-07/CommunicationIdentity.json +title: + Azure Communication Services +``` + +### Tag: package-acssms-2021-03-07 + +These settings apply only when `--tag=package-acssms-2021-03-07` is specified on the command line. + +```yaml $(tag) == 'package-acssms-2021-03-07' +input-file: - Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json title: Azure Communication Services From 75c1fb7e43d0b43e52dad886467275c16a197f8b Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Fri, 19 Feb 2021 12:56:44 -0800 Subject: [PATCH 48/50] removing acs --- specification/communication/data-plane/readme.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/communication/data-plane/readme.md b/specification/communication/data-plane/readme.md index 0dfa8595434d..d30602a2ddfc 100644 --- a/specification/communication/data-plane/readme.md +++ b/specification/communication/data-plane/readme.md @@ -88,11 +88,11 @@ title: Azure Communication Services ``` -### Tag: package-acssms-2021-03-07 +### Tag: package-sms-2021-03-07 -These settings apply only when `--tag=package-acssms-2021-03-07` is specified on the command line. +These settings apply only when `--tag=package-sms-2021-03-07` is specified on the command line. -```yaml $(tag) == 'package-acssms-2021-03-07' +```yaml $(tag) == 'package-sms-2021-03-07' input-file: - Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json title: From 83da5da91076e457e03ae7bb5b37d214b78c62ff Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Fri, 26 Feb 2021 10:50:54 -0800 Subject: [PATCH 49/50] Updating swagger for require EnableDelivery report option. --- .../stable/2021-03-07/communicationservicessms.json | 3 +-- .../stable/2021-03-07/examples/send.json | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json index cc67cba7334d..7dd4ff3b3aaa 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/communicationservicessms.json @@ -95,8 +95,7 @@ "properties": { "enableDeliveryReport": { "description": "Enable this flag to receive a delivery report for this message on the Azure Resource EventGrid.", - "type": "boolean", - "default": false + "type": "boolean" }, "tag": { "description": "Use this field to provide metadata that will then be sent back in the corresponding Delivery Report.", diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index 35e260e6bddd..a866c1d228d0 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -27,7 +27,8 @@ ], "message": "Hello world!", "smsSendOptions": { - "enableDeliveryReport": true + "enableDeliveryReport": true, + "tag": "testSmsRequest" } }, "api-version": "2021-03-07", From ee9b950b4e9b4c8f9b1ffcb47469e00aef0dd4b2 Mon Sep 17 00:00:00 2001 From: Shamsha Khan Date: Fri, 26 Feb 2021 13:40:17 -0800 Subject: [PATCH 50/50] prettier run. --- .../stable/2021-03-07/examples/send.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json index a866c1d228d0..6dc8b8616279 100644 --- a/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json +++ b/specification/communication/data-plane/Microsoft.CommunicationServicesSms/stable/2021-03-07/examples/send.json @@ -28,7 +28,7 @@ "message": "Hello world!", "smsSendOptions": { "enableDeliveryReport": true, - "tag": "testSmsRequest" + "tag": "testSmsRequest" } }, "api-version": "2021-03-07",