Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManagementLocks_Get in resource/locks incorrect + missing operations #394

Closed
lmazuel opened this issue Jul 13, 2016 · 0 comments · Fixed by #666
Closed

ManagementLocks_Get in resource/locks incorrect + missing operations #394

lmazuel opened this issue Jul 13, 2016 · 0 comments · Fixed by #666

Comments

@lmazuel
Copy link
Member

lmazuel commented Jul 13, 2016

The way the "scope" is made in the "lock" RestApi implies that each call to the RestApi must be translated in three operations in the Swagger file:

  • At Subscription Level
  • At Resource Group Level
  • At Resource Level

For instance, we have for "create_or_update":

  • ManagementLocks_CreateOrUpdateAtSubscriptionLevel
  • ManagementLocks_CreateOrUpdateAtResourceGroupLevel
  • ManagementLocks_CreateOrUpdateAtResourceLevel

However the "get" operation is currently defined as:

        "operationId": "ManagementLocks_Get",
        "description": "Gets the management lock of a scope.",

which let us suppose that it's a generic operation able to get the three scopes. Unfortunately, this get is the "subscription_level" get.

We need to:

  • Rename ManagementLocks_Get to ManagementLocks_GetAtSubscriptionLevel
  • Add ManagementLocks_GetAtResourceGroupLevel
  • Add ManagementLocks_GetAtResourceLevel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant