Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Api Management] DELETE should return 200 along with 204 #1847

Closed
solankisamir opened this issue Oct 11, 2017 · 4 comments
Closed

[Api Management] DELETE should return 200 along with 204 #1847

solankisamir opened this issue Oct 11, 2017 · 4 comments
Assignees
@marstr

Comments

@solankisamir
Copy link
Member

solankisamir commented Oct 11, 2017 •
edited by azuresdkci
Loading

Based on https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#delete-resource we need to support 200 for case where entity is actually deleted.

Currently, we only support 204 on DELETE. This will require a version change, as the entities are already published.
@solankisamir solankisamir changed the title [Api Management] DELETE should support 200 [Api Management] DELETE should return 200 along with 204 Oct 11, 2017
@solankisamir solankisamir mentioned this issue Oct 11, 2017
Merged
10 tasks
@marstr
Copy link
Member

marstr commented Nov 9, 2017

Seems like this was completed in the PR linked above. I'm going to close this out.

@marstr marstr closed this as completed Nov 9, 2017
@solankisamir
Copy link
Member Author

No, it was not fixed. @marstr please open it. We are working on these changes in Service Side.

@marstr marstr reopened this Nov 9, 2017
@marstr
Copy link
Member

marstr commented Nov 9, 2017

Is there someone with more context on this issue that would be a more appropriate assignee than me?

@solankisamir solankisamir mentioned this issue Jan 10, 2018
Merged
10 tasks
@solankisamir solankisamir mentioned this issue Jan 18, 2018
Merged
10 tasks
@solankisamir
Copy link
Member Author

The service side changes done and fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marstr marstr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@solankisamir @marstr