Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues found by PVS-Studio #10223

Closed
skhrenov opened this issue Oct 9, 2019 · 1 comment · Fixed by #14362, #14363, #14364, #14365 or #14366
Closed

Issues found by PVS-Studio #10223

skhrenov opened this issue Oct 9, 2019 · 1 comment · Fixed by #14362, #14363, #14364, #14365 or #14366
Assignees
Milestone

Comments

@skhrenov
Copy link

skhrenov commented Oct 9, 2019

Hello,
I have found a few bugs using PVS-Studio analyzer.
PVS-Studio is a static code analyzer for C, C++, C#, and Java.
I gave the description of errors and code fragments in the article.
You can read the article at the official site: https://www.viva64.com/en/b/0678/

@skhrenov skhrenov added the triage label Oct 9, 2019
@anton-evseev
Copy link
Contributor

@skhrenov thanks! Suggestion: maybe it would be better open issues if not by individual bugs, but by resource providers (Accounts / Compute / Network / RescoveryServices / etc)


From Network's side, @vinayada1, could you please take a look at Remove-AzExpressRouteConnection? Is there a reason for why this is written that way:

if (ParameterSetName.Equals(CortexParameterSetNames.ByExpressRouteConnectionName, StringComparison.OrdinalIgnoreCase))
{
    this.ResourceGroupName = this.ResourceGroupName;
    this.ExpressRouteGatewayName = this.ExpressRouteGatewayName;
    this.Name = this.Name;
}

https://github.com/Azure/azure-powershell/blob/master/src/Network/Network/Cortex/ExpressRouteGateway/ExpressRouteConnection/RemoveAzureRmExpressRouteConnectionCommand.cs#L84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment