Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load worker jars regardless of the user have lib folder or not in their function #393

Closed
amamounelsayed opened this issue Jul 30, 2020 · 2 comments · Fixed by #394
Closed

Comments

@amamounelsayed
Copy link
Contributor

amamounelsayed commented Jul 30, 2020

There is one edge case that we do not load the java worker jars in case there is no lib folder in the java functions.

Impact

  • if the user has dependencies
  • And depend on the java worker only for any of the jars they need.
  • And they did not have any lib jars folder in their functions.

This will fail loading their jars as we shaded the worker now and in this case we did not load the worker jars.

@amamounelsayed
Copy link
Contributor Author

cc @yojagad - current release owner, @fabiocav @anirudhgarg

@amamounelsayed
Copy link
Contributor Author

@fabiocav I am creating hotfix for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant