Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exponential backoff for ScriptHostManager error/restart #760

Closed
mathewc opened this issue Oct 11, 2016 · 0 comments
Closed

Add exponential backoff for ScriptHostManager error/restart #760

mathewc opened this issue Oct 11, 2016 · 0 comments
Labels
Milestone

Comments

@mathewc
Copy link
Member

mathewc commented Oct 11, 2016

The current logic we have in place for restarts is overly simple and suboptimal (code here). We currently use a constant interval (defaults to 5 seconds, configurable via ScriptHostConfiguration.RestartInterval.

We should put a simple linear (or perhaps exponential) backoff algorithm in place, e.g. starts at 5 seconds and increases 10, 15, etc. to a maximum of 1 minute. We'd then rename the knob to ScriptHostConfiguration.MinRestartInterval. Whenever a host level restart is triggered via a file event, etc. we should reset this interval and break out of any in progress wait. That ensures that we remain responsive during development, while optimizing for production steady state transient failures.

@christopheranderson christopheranderson added this to the Next - Triaged milestone Oct 17, 2016
@mathewc mathewc closed this as completed Feb 2, 2017
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants