Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AOT] Replace usage of IConfiguration.Bind #1055

Closed
Tracked by #1056
kshyju opened this issue Sep 20, 2022 · 2 comments
Closed
Tracked by #1056

[AOT] Replace usage of IConfiguration.Bind #1055

kshyju opened this issue Sep 20, 2022 · 2 comments

Comments

@kshyju
Copy link
Member

kshyju commented Sep 20, 2022

IConfiguration.Bind is not trimmer friendly.

See dotnet/runtime#59230

We use this method to bind to GrpcWorkerStartupOptions type, which is to represent the data from the command line arguments sent from host

services.AddOptions<GrpcWorkerStartupOptions>()
.Configure<IConfiguration>((arguments, config) =>
{
config.Bind(arguments);
});

@jviau
Copy link
Contributor

jviau commented Sep 20, 2022

Relevant: dotnet/runtime#44493

@kshyju
Copy link
Member Author

kshyju commented Oct 19, 2023

This issue is fixed with #1897

@kshyju kshyju closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants