Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ed25519 support in CLI for Public Preview #27689

Open
srijang opened this issue Oct 25, 2023 · 9 comments
Open

Enable ed25519 support in CLI for Public Preview #27689

srijang opened this issue Oct 25, 2023 · 9 comments
Labels
Service Attention This issue is responsible by Azure service team.

Comments

@srijang
Copy link

srijang commented Oct 25, 2023

Related command

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 25, 2023

Thank you for opening this issue, we will look into it.

@yonzhan yonzhan added the Service Attention This issue is responsible by Azure service team. label Oct 26, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 26, 2023

Please provide more detailed info such as CLI command and swagger spec link.

@kamusta-msft
Copy link
Member

hey @yonzhan, we need assistance with a new feature we're rolling out. We're modifying the generateSshKeyPair API and need to update the CLI to reflect those changes. The generateSshKeyPair now has a response body that takes in the "encryptionType" property. The allowed values of this property are either "RSA" or "Ed25519". Looking at our existing docs, this cli will need to get updated: https://learn.microsoft.com/en-us/cli/azure/vm?view=azure-cli-latest#az-vm-create (--generate-ssh-keys). One possible update would be to turn this from a true/false to a flag that requires a property. I've pasted the Swagger Spec below:

Azure/azure-rest-api-specs#26090

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Oct 27, 2023

@kamusta-msft @srijang Could you please use this template [Microsoft Internal / Service Team] Feature Request to create this feature request? It contains more necessary information for us to develop, such as whether the Python SDK is ready and the ETA. Then we will evaluate the effort and priority of it to plan its development and release.

@AkechiShiro
Copy link

Damn, finally this feature is getting worked on, wow, RSA was getting a bit old, I'm happy it's moving forward.

@dkrish24
Copy link

The Azure CLI is supporting this but Key Vault is only supporting RSA or ECC. When is it expected to be released across both?

az-vm-create

@AkechiShiro
Copy link

I'll also add that the Azure STA does not support ed25519 as of now. Despite, support having landed for VM ssh authentication

@yanzhudd
Copy link
Contributor

Azure CLI has already supported Ed25519 when creating a VM.
You can run "az vm create" command with "--generate-ssh-keys --ssh-key-type Ed25519" parameters to generate Ed25519 SSH key when creating a VM

@dkrish24
Copy link

Yes that is true but one cannot store the key pair in the Key Vault

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Service Attention This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

7 participants